-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Security must be a local file, not from repository #100
feat: Security must be a local file, not from repository #100
Conversation
3e04755
to
bff7dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for me, the only thing is I have a concern about the create Service:
internal/service/create/create.go:65
It handles a lot of responsibilities, module configuration, git sources, security configuration, component archives, registry operations, module templates, CRD parsing, and file resolution.
But I think, we can work on it in a separate issue. What do you thinnk?
Thanks! I have some doubts that there is a significant improvement possible. Eventually, The |
Yes,As we discussed maybe we can think about another naming if It's an orchestrator and not a in a sense of a service. I will rethink about potential naming to this encapsulating struct. Thanks Christoph! |
Description
Changes proposed in this pull request:
Related issue(s)