fix: Support default CR starting with dashes #149
Conversation
There was a problem hiding this comment.
Consider it approved with suggestion :) The change looks good, one suggestion would be if we could consider streamlining the test cases (only if time allows and you feel like doing it)...
It looks as if we have a set of very similar tests where each is having a shared core (the minimal information that is put into the module template) and each test adding a small part on top (e.g., when associated resources are present, when downtime is set, ...) Would it be possible to use the pattern with an array of test cases where we pass assert functions to the test case? We could have one assert function that is used by all tests verifying the common part, and then pass one function that verifies the specific addition by this test. This would make it easier to see the common part, the individual changes by each test, and make it more robust if things change in the common part in the future.
nesmabadr
force-pushed
the
remove_yaml_separators
branch
from
c5b3ffd to
43fbb82
Compare
nesmabadr
force-pushed
the
remove_yaml_separators
branch
from
74f16de to
e9a0899
Compare
nesmabadr
force-pushed
the
remove_yaml_separators
branch
from
e9a0899 to
d0d0098
Compare
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #143