Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize the RBAC kubebuilder markers in telemetry manager #1546

Open
rakesh-garimella opened this issue Oct 22, 2024 · 0 comments
Open

Harmonize the RBAC kubebuilder markers in telemetry manager #1546

rakesh-garimella opened this issue Oct 22, 2024 · 0 comments
Assignees

Comments

@rakesh-garimella
Copy link
Contributor

rakesh-garimella commented Oct 22, 2024

Description

We have mentioned bunch of the rbac rules via kubebuilder markers and these are not clear as to which rule is for what purpose. These rules can be refactored in such a way they are mentioned where these rules are actually needed.

However during this task we should also refactor the code in rbac.go, such that we could have rbac rules clearly mentioned as to for which receiver/processor etc these rules are for.

Currently kubebuilder annotations are not clear and difficult follow as to which roles are required for which resource.
We can remove these annotations from the controller and create multiple roles belonging to which component or feature.

Criterias:

  • The rbacs are refactored in such a way there clear for which components they are needed
  • The annotations are removed and we handle these in kustomize with proper documentation. May be by creating seaparate roles ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants