Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate from kubebuilder RBAC annotations to commented kustomize #1622

Merged
merged 11 commits into from
Dec 2, 2024
Merged

chore: Migrate from kubebuilder RBAC annotations to commented kustomize #1622

merged 11 commits into from
Dec 2, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Nov 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Migrate from kubebuilder annotations to commented role.yaml specifying which RBAC are needed by which components
  • Improves understanding RBACs needed by specific components
  • Remove unused files scaffolded by kubebuilder

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2024
@jeffreylimnardy jeffreylimnardy added kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Nov 21, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.29.0 milestone Nov 21, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2024
@jeffreylimnardy jeffreylimnardy marked this pull request as ready for review November 25, 2024 14:20
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner November 25, 2024 14:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@TeodorSAP TeodorSAP removed the request for review from rakesh-garimella November 26, 2024 08:43
@hisarbalik hisarbalik self-assigned this Dec 2, 2024
@jeffreylimnardy jeffreylimnardy enabled auto-merge (squash) December 2, 2024 09:55
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 2, 2024
@jeffreylimnardy jeffreylimnardy merged commit 933482c into kyma-project:main Dec 2, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella left review comments

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

@hisarbalik hisarbalik

@rakesh-garimella rakesh-garimella

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffreylimnardy @k15r @rakesh-garimella @hisarbalik @kyma-bot