Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Self-monitor logs in JSON format #1242

Merged
merged 5 commits into from
Jul 8, 2024
Merged

feat: Self-monitor logs in JSON format #1242

merged 5 commits into from
Jul 8, 2024

Conversation

a-thaler
Copy link
Collaborator

@a-thaler a-thaler commented Jul 2, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Adjusted command args of prometheus to log in JSON
  • Externalized constants which are re-used to assure the proper usage of them

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The PR has a milestone set.
  • The PR has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler requested a review from a team as a code owner July 2, 2024 16:47
@a-thaler a-thaler added this to the 1.20.0 milestone Jul 2, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2024
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels Jul 2, 2024
@skhalash skhalash self-assigned this Jul 3, 2024
k15r
k15r reviewed Jul 3, 2024
View reviewed changes
internal/resources/selfmonitor/resources.go Outdated Show resolved Hide resolved
internal/resources/selfmonitor/resources.go Outdated Show resolved Hide resolved
internal/selfmonitor/config/config_builder.go Outdated Show resolved Hide resolved
@skhalash skhalash assigned a-thaler and unassigned skhalash Jul 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2024
@kyma-bot kyma-bot merged commit e616d62 into kyma-project:main Jul 8, 2024
31 checks passed
@a-thaler a-thaler deleted the json branch July 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

@a-thaler a-thaler

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@a-thaler @k15r @skhalash @kyma-bot