Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for custom multiline filter #1259

Merged
merged 10 commits into from
Jul 10, 2024
Merged

feat: Add support for custom multiline filter #1259

merged 10 commits into from
Jul 10, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Jul 9, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove multiline from the denied filter plugins list
  • Add support multiline filter via LogPipeline custom filters
  • Ensure the multiline filters are the first filter in the pipeline filter chain

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The PR has a milestone set.
  • The PR has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner July 9, 2024 14:16
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2024
@hisarbalik hisarbalik added area/logs LogPipeline and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 9, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2024
@hisarbalik hisarbalik added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 9, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2024
@hisarbalik hisarbalik changed the title feat: Enable custom multiline filter for logpiplines feat: Add support custom multiline filter to the LogPipelines Jul 9, 2024
@hisarbalik hisarbalik requested a review from a team as a code owner July 9, 2024 14:27
@hisarbalik hisarbalik removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@skhalash skhalash self-assigned this Jul 10, 2024
@hisarbalik hisarbalik changed the title feat: Add support custom multiline filter to the LogPipelines feat: Add support for custom multiline filter Jul 10, 2024
skhalash
skhalash requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@skhalash skhalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments

internal/fluentbit/config/builder/custom_filter.go Outdated Show resolved Hide resolved
internal/fluentbit/config/builder/custom_filter.go Outdated Show resolved Hide resolved
internal/fluentbit/config/builder/config_builder.go Outdated Show resolved Hide resolved
@a-thaler a-thaler added this to the 1.20.0 milestone Jul 10, 2024
NHingerl
NHingerl previously approved these changes Jul 10, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 10, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 10, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@hisarbalik hisarbalik added the area/documentation Documentation changes label Jul 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 10, 2024
@kyma-bot kyma-bot merged commit a8ef05b into kyma-project:main Jul 10, 2024
33 checks passed
@hisarbalik hisarbalik deleted the add-multiline-log-parser branch July 10, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hisarbalik @skhalash @NHingerl @a-thaler @kyma-bot