Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow collecting Telemetry module status metrics in development variant #1321

Merged
merged 26 commits into from
Aug 8, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Aug 4, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Move the KymaInputAllowed field from the MetricPipeline controller config to the reconciler config, so that it can be passed down to the gateway config builder

  • When the feature flag --kyma-input-allowed is true and a MetricPipeline exists with the annotation telemetry.kyma-project.io/experimental-kyma-input set to true, then the Telemetry module status metrics are collected by the Metric Gateway. This is done by running a kymastatsreceiver wrapped inside a singletonreceivercreator

  • For the instrumentationScope of the Kyma status metrics, set the name to io.kyma-project.telemetry/kyma and set the version to the value of the module version (same as for other inputs)

  • Move the transform processor for setting the instrumentationScope from the internal/otelcollector/config/metric/agent pkg to the internal/otelcollector/config/metric pkg to make it accessible for both the agent and the gateway

  • Rename the e2e test label v1beta1 to experimental so that it can be used for labelling tests of all experimental features

  • Adjust the creation of the FlatMetric in the e2e testkit to be created for each metric data point and not just one instance for all the metric data points.

  • Add unit and e2e tests

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline labels Aug 4, 2024
@shorim shorim added this to the 1.22.0 milestone Aug 4, 2024
@shorim shorim requested a review from a team as a code owner August 4, 2024 22:33
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 4, 2024
@shorim shorim added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2024
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
@kyma-bot kyma-bot merged commit ccd9872 into kyma-project:main Aug 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants