generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow collecting Telemetry module status metrics in development variant #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorim
added
kind/feature
Categorizes issue or PR as related to a new feature.
area/metrics
MetricPipeline
labels
Aug 4, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Aug 4, 2024
shorim
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 5, 2024
kyma-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Aug 6, 2024
# Conflicts: # internal/reconciler/metricpipeline/reconciler_test.go
shorim
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 6, 2024
skhalash
reviewed
Aug 7, 2024
skhalash
reviewed
Aug 7, 2024
skhalash
reviewed
Aug 7, 2024
skhalash
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
MetricPipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
Move the
KymaInputAllowed
field from the MetricPipeline controller config to the reconciler config, so that it can be passed down to the gateway config builderWhen the feature flag
--kyma-input-allowed
is true and a MetricPipeline exists with the annotationtelemetry.kyma-project.io/experimental-kyma-input
set to true, then the Telemetry module status metrics are collected by the Metric Gateway. This is done by running a kymastatsreceiver wrapped inside a singletonreceivercreatorFor the instrumentationScope of the Kyma status metrics, set the name to
io.kyma-project.telemetry/kyma
and set the version to the value of the module version (same as for other inputs)Move the transform processor for setting the instrumentationScope from the
internal/otelcollector/config/metric/agent
pkg to theinternal/otelcollector/config/metric
pkg to make it accessible for both the agent and the gatewayRename the e2e test label
v1beta1
toexperimental
so that it can be used for labelling tests of all experimental featuresAdjust the creation of the
FlatMetric
in the e2e testkit to be created for each metric data point and not just one instance for all the metric data points.Add unit and e2e tests
Changes refer to particular issues, PRs or documents:
Traceability
Related Issues
section.