Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add styleguide and document error handling #1338

Merged
merged 8 commits into from
Aug 23, 2024
Merged

docs: Add styleguide and document error handling #1338

merged 8 commits into from
Aug 23, 2024

Conversation

skhalash
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Adds a place to put team-wide coding decisions
  • Document error handling

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added area/documentation Documentation changes kind/docs Categorizes issue or PR as related to a documentation change labels Aug 12, 2024
@skhalash skhalash added this to the 1.22.0 milestone Aug 12, 2024
@skhalash skhalash requested a review from a team as a code owner August 12, 2024 09:40
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
NHingerl
NHingerl reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful and well-written document!

docs/contributor/styleguide/error_handling.md Outdated Show resolved Hide resolved
docs/contributor/styleguide/error_handling.md Outdated Show resolved Hide resolved
docs/contributor/styleguide/error_handling.md Outdated Show resolved Hide resolved
@NHingerl
Apply suggestions from code review
3bb66f3 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 23, 2024
@kyma-bot kyma-bot merged commit 19e9b7b into kyma-project:main Aug 23, 2024
22 checks passed
@skhalash skhalash deleted the document-error-handling branch August 23, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorSAP TeodorSAP TeodorSAP approved these changes

@NHingerl NHingerl NHingerl approved these changes

@shorim shorim shorim approved these changes

Assignees

@shorim shorim

@NHingerl NHingerl

@TeodorSAP TeodorSAP

Labels
area/documentation Documentation changes cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@skhalash @shorim @NHingerl @TeodorSAP @kyma-bot