Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improved metrics troubleshooting #1413

Merged
merged 13 commits into from
Sep 5, 2024
Merged

docs: Improved metrics troubleshooting #1413

merged 13 commits into from
Sep 5, 2024

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • For scraping workload via prometheus annotation in combination with Istio, it is essential that the Service definition reveals the used appProtocol. Added a section to explain it and improved troubleshooting guide to cover the symptom

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler requested a review from a team as a code owner August 30, 2024 11:52
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2024
@a-thaler a-thaler added kind/bug Categorizes issue or PR as related to a bug. area/documentation Documentation changes and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 30, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2024
@a-thaler a-thaler added this to the 1.23.0 milestone Aug 30, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
@a-thaler a-thaler added kind/docs Categorizes issue or PR as related to a documentation change and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 30, 2024
NHingerl
NHingerl reviewed Sep 2, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
a-thaler and others added 5 commits September 2, 2024 11:38
@a-thaler
fix
6d672d2
@a-thaler @NHingerl
Apply suggestions from code review
0037f40 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@a-thaler
fix
c1d7caf
@a-thaler
fix
8b1266f
@a-thaler
Merge branch 'main' into docu
ec3d32f
NHingerl
NHingerl reviewed Sep 3, 2024
View reviewed changes
docs/user/04-metrics.md Show resolved Hide resolved
docs/user/04-metrics.md Show resolved Hide resolved
@NHingerl
Copy link
Contributor

NHingerl commented Sep 3, 2024

I've synced the DITA doc

@hisarbalik hisarbalik self-assigned this Sep 4, 2024
a-thaler and others added 2 commits September 4, 2024 14:38
@a-thaler @NHingerl
Apply suggestions from code review
b0bea1a 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@a-thaler
fix
6b60dd9
NHingerl
NHingerl previously approved these changes Sep 4, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 4, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 4, 2024
@NHingerl
Copy link
Contributor

NHingerl commented Sep 5, 2024

Help Portal already shows the updated version: https://help.sap.com/docs/btp/sap-business-technology-platform/application-logs-12871325f46f48f6b4340c8ef47bdc66?locale=en-US&version=Cloud 🥳

NHingerl
NHingerl reviewed Sep 5, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
NHingerl
NHingerl reviewed Sep 5, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
@a-thaler @NHingerl
Apply suggestions from code review
245b90f 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 5, 2024
@kyma-bot kyma-bot merged commit 63412bd into kyma-project:main Sep 5, 2024
34 checks passed
@a-thaler a-thaler deleted the docu branch October 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko left review comments

@NHingerl NHingerl NHingerl approved these changes

Assignees

@hisarbalik hisarbalik

@NHingerl NHingerl

Labels
area/documentation Documentation changes cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@a-thaler @NHingerl @nataliasitko @hisarbalik @kyma-bot