Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Increase the rsa key size #1433

Merged
merged 16 commits into from
Sep 17, 2024
Merged

feat: Increase the rsa key size #1433

merged 16 commits into from
Sep 17, 2024

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Sep 10, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • change rsa key size to 4096

  • check the current key. If its not 4096 bits long then regenerate it.

  • Increase the CPU time and intialdelay for livenessprobe as generating the cert with 4096 bits is CPU intensive. It might sometimes take long for the generation and during this time the liveness probe might fail causing restart of the container.
    Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella added this to the 1.24.0 milestone Sep 10, 2024
@rakesh-garimella rakesh-garimella requested a review from a team as a code owner September 10, 2024 12:40
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2024
@rakesh-garimella rakesh-garimella added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 10, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2024
@rakesh-garimella rakesh-garimella changed the title fix: Increase the rsa key size feat: Increase the rsa key size Sep 10, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
skhalash
skhalash requested changes Sep 13, 2024
View reviewed changes
internal/webhookcert/ca_cert_provider.go Outdated Show resolved Hide resolved
internal/webhookcert/ca_cert_provider.go Outdated Show resolved Hide resolved
internal/webhookcert/ca_cert_provider.go Outdated Show resolved Hide resolved
internal/webhookcert/ca_key_length_checker.go Outdated Show resolved Hide resolved
internal/webhookcert/ca_key_length_checker.go Outdated Show resolved Hide resolved
internal/webhookcert/ca_cert_provider.go Show resolved Hide resolved
rakesh-garimella and others added 3 commits September 13, 2024 13:16
@rakesh-garimella
Apply suggestions from code review
0a54238 
Co-authored-by: Stanislav Khalash <stanislav.khalash@gmail.com>
@rakesh-garimella
fixes based on review comments
094c399
@rakesh-garimella
fix
462526c
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 13, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 16, 2024
@kyma-bot kyma-bot merged commit c00f0c8 into kyma-project:main Sep 17, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rakesh-garimella @skhalash @kyma-bot