Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ADR Self Monitor Storage #1436

Merged
merged 13 commits into from
Sep 11, 2024
Merged

docs: ADR Self Monitor Storage #1436

merged 13 commits into from
Sep 11, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Sep 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add an ADR to propose the Telemetry self-monitoring storage configuration

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner September 11, 2024 06:47
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2024
@hisarbalik hisarbalik added area/documentation Documentation changes area/manager Manager or module changes kind/docs Categorizes issue or PR as related to a documentation change do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 11, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2024
@hisarbalik hisarbalik added this to the 1.24.0 milestone Sep 11, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2024
NHingerl
NHingerl reviewed Sep 11, 2024
View reviewed changes
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
docs/contributor/arch/014-telemetry-self-monitor-storage.md Outdated Show resolved Hide resolved
hisarbalik and others added 2 commits September 11, 2024 12:09
@hisarbalik @NHingerl
Apply suggestions from code review
734c66d 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@hisarbalik
updated
83b4262
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2024
@hisarbalik @NHingerl
Apply suggestions from code review
4dcffa0 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
NHingerl
NHingerl previously approved these changes Sep 11, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 11, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 11, 2024
@hisarbalik hisarbalik removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 11, 2024
@kyma-bot kyma-bot merged commit 4d8f55d into kyma-project:main Sep 11, 2024
34 checks passed
@hisarbalik hisarbalik deleted the add-self-monitor-storage-adr branch September 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

Assignees

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hisarbalik @NHingerl @kyma-bot