Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Endpoint validation with path and port scenario #1492

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix: Endpoint validation with path and port scenario #1492

merged 3 commits into from
Oct 2, 2024

Conversation

TeodorSAP
Copy link
Member

@TeodorSAP TeodorSAP commented Oct 2, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Fix an untreated scenario in the endpoint validation logic (OTLP GRPC endpoint with path and port)

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP requested a review from a team as a code owner October 2, 2024 09:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
@TeodorSAP TeodorSAP added kind/bug Categorizes issue or PR as related to a bug. area/metrics MetricPipeline area/traces TracePipeline and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 2, 2024
@TeodorSAP TeodorSAP added this to the 1.25.0 milestone Oct 2, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 2, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 2, 2024
@TeodorSAP TeodorSAP enabled auto-merge (squash) October 2, 2024 10:00
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 2, 2024

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 2, 2024
@TeodorSAP TeodorSAP merged commit bfc92ee into kyma-project:main Oct 2, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

Assignees

@rakesh-garimella rakesh-garimella

Labels
area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TeodorSAP @kyma-bot @rakesh-garimella