Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Cloud Logging dashboards for new metric features #1494

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

a-thaler
Copy link
Collaborator

@a-thaler a-thaler commented Oct 2, 2024

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler added area/documentation Documentation changes kind/docs Categorizes issue or PR as related to a documentation change labels Oct 2, 2024
@a-thaler a-thaler added this to the 1.25.0 milestone Oct 2, 2024
@a-thaler a-thaler requested a review from a team as a code owner October 2, 2024 20:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2024
@rakesh-garimella rakesh-garimella self-assigned this Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 7, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 7, 2024
@NHingerl
Copy link
Contributor

NHingerl commented Oct 8, 2024

I'll adjust the docs in DITA once we're ready.
Does this have to happen together with the 1.25 release?

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 8, 2024
@a-thaler a-thaler enabled auto-merge (squash) October 10, 2024 11:23
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 10, 2024
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating Integrate with SAP Cloud Logging accordingly, Dev Draft version should show the update soon

docs/user/integration/sap-cloud-logging/README.md Outdated Show resolved Hide resolved
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@a-thaler a-thaler merged commit edaab6a into kyma-project:main Oct 10, 2024
8 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 10, 2024
@NHingerl
Copy link
Contributor

NHingerl commented Oct 14, 2024

wait, did this now move to 1.26 milestone?
Then the Help Portal page mustn't be updated before 1.26 release. I'll have to hide I won't push the changes to SHIP till then.

@a-thaler a-thaler deleted the cls branch October 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation changes cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants