Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add new cloud logging dashboard for k8s volumes #1528

Merged
merged 3 commits into from
Oct 17, 2024
Merged

docs: Add new cloud logging dashboard for k8s volumes #1528

merged 3 commits into from
Oct 17, 2024

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Adds a new dashboard for K8s volumes to the Cloud Logging integration guide

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler added area/documentation Documentation changes area/metrics MetricPipeline kind/docs Categorizes issue or PR as related to a documentation change labels Oct 15, 2024
@a-thaler a-thaler added this to the 1.26.0 milestone Oct 15, 2024
@a-thaler a-thaler requested a review from a team as a code owner October 15, 2024 15:37
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
@a-thaler a-thaler mentioned this pull request Oct 14, 2024
Closed
13 tasks
NHingerl
NHingerl reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the abbreviation for Kubernetes

Are the files really called "K8s xyz"?
If yes, keep the link title. Otherwise, find a better title that doesn't use the abbreviation.

docs/user/integration/sap-cloud-logging/README.md Outdated Show resolved Hide resolved
docs/user/integration/sap-cloud-logging/README.md Outdated Show resolved Hide resolved
@a-thaler @NHingerl
Apply suggestions from code review
4fa3b37 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 16, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 17, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@hisarbalik hisarbalik enabled auto-merge (squash) October 17, 2024 07:46
@hisarbalik hisarbalik merged commit 4f13e75 into kyma-project:main Oct 17, 2024
12 checks passed
@NHingerl
Copy link
Contributor

Updated in DITA ✔️

@a-thaler a-thaler deleted the cls2 branch October 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

Assignees

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@a-thaler @kyma-bot @NHingerl @hisarbalik