Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix MetricPipeline input docs #1540

Merged
merged 7 commits into from
Oct 22, 2024
Merged

docs: Fix MetricPipeline input docs #1540

merged 7 commits into from
Oct 22, 2024

Conversation

skhalash
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Fix istio and prometheus MetricPipeline input docs

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added area/documentation Documentation changes area/metrics MetricPipeline kind/docs Categorizes issue or PR as related to a documentation change labels Oct 21, 2024
@skhalash skhalash added this to the 1.26.0 milestone Oct 21, 2024
@skhalash skhalash requested a review from a team as a code owner October 21, 2024 10:00
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 21, 2024
@skhalash skhalash requested a review from a team as a code owner October 21, 2024 10:02
@skhalash @a-thaler
Update apis/telemetry/v1alpha1/metricpipeline_types.go
46ea276 
Co-authored-by: Andreas Thaler <andreas.thaler01@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
@a-thaler a-thaler modified the milestones: 1.26.0, 1.27.0 Oct 21, 2024
@skhalash skhalash enabled auto-merge (squash) October 21, 2024 17:32
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 22, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@skhalash skhalash merged commit f0bf09d into kyma-project:main Oct 22, 2024
40 checks passed
@skhalash skhalash deleted the fix-metric-pipeline-input-docs branch October 22, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@a-thaler a-thaler a-thaler approved these changes

Assignees

@a-thaler a-thaler

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skhalash @kyma-bot @a-thaler @NHingerl