Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Istio proxy metric merge ADR #1544

Merged
merged 10 commits into from
Oct 23, 2024
Merged

docs: Istio proxy metric merge ADR #1544

merged 10 commits into from
Oct 23, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Write an ADR about the impact of Istio Prometheus Merge feature on MetricPipelines

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 21, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2024
@skhalash skhalash changed the title wip: Istio proxy metric merge ADR docs: Istio proxy metric merge ADR Oct 22, 2024
@skhalash skhalash added this to the 1.27.0 milestone Oct 22, 2024
@skhalash skhalash marked this pull request as ready for review October 22, 2024 07:28
@skhalash skhalash requested a review from a team as a code owner October 22, 2024 07:28
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@skhalash skhalash added kind/docs Categorizes issue or PR as related to a documentation change area/metrics MetricPipeline labels Oct 22, 2024
NHingerl
NHingerl reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent document!

docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Show resolved Hide resolved
docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Outdated Show resolved Hide resolved
docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Outdated Show resolved Hide resolved
docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Outdated Show resolved Hide resolved
docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Outdated Show resolved Hide resolved
docs/contributor/arch/015-impact-of-istio-prometheus-merge-on-metric-pipelines.md Outdated Show resolved Hide resolved
@skhalash @NHingerl
Apply suggestions from code review
d91d28b 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 23, 2024
@skhalash skhalash enabled auto-merge (squash) October 23, 2024 12:51
@skhalash skhalash merged commit 8c78006 into kyma-project:main Oct 23, 2024
17 checks passed
@skhalash skhalash deleted the istio-prom-metric-merge-adr branch October 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@shorim shorim shorim approved these changes

Assignees

@shorim shorim

@NHingerl NHingerl

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skhalash @shorim @NHingerl @kyma-bot