Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix otel backend configuration in sample manifests #1569

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: Fix otel backend configuration in sample manifests #1569

merged 3 commits into from
Oct 28, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Oct 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • The default host configuration was changed from 0.0.0.0 to localhost, due to this change, the gateway could not access the backend.
  • This PR changes the configuration to explicitly use 0.0.0.0

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added kind/bug Categorizes issue or PR as related to a bug. area/metrics MetricPipeline area/traces TracePipeline labels Oct 28, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner October 28, 2024 09:39
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.27.0 milestone Oct 28, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 28, 2024
@skhalash skhalash enabled auto-merge (squash) October 28, 2024 09:53
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 28, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@skhalash skhalash merged commit e5eca73 into kyma-project:main Oct 28, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @kyma-bot @skhalash