Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve runtime resources metrics example #1573

Merged
merged 3 commits into from
Oct 29, 2024
Merged

docs: Improve runtime resources metrics example #1573

merged 3 commits into from
Oct 29, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Oct 29, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Improve the example for runtime resources metrics, so that some metrics which are not enabled by default are explicitly enabled in the example

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added area/metrics MetricPipeline kind/docs Categorizes issue or PR as related to a documentation change labels Oct 29, 2024
@shorim shorim added this to the 1.27.0 milestone Oct 29, 2024
@shorim shorim requested a review from a team as a code owner October 29, 2024 12:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 29, 2024
@NHingerl NHingerl added the area/documentation Documentation changes label Oct 29, 2024
@NHingerl
Copy link
Contributor

NHingerl commented Oct 29, 2024 •
edited
Loading

Follow-up to PR #1530.

@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 29, 2024
@shorim shorim enabled auto-merge (squash) October 29, 2024 13:28
@shorim shorim merged commit ae77f96 into kyma-project:main Oct 29, 2024
12 checks passed
@NHingerl
Copy link
Contributor

updated DITA accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

Assignees

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorim @NHingerl @kyma-bot