refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
|
|
Hi @Juneezee. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kyma-bot
added
the
size/XS
|
/ok-to-test |
|
/test all |
Ressetkk
approved these changes
Mar 3, 2023
|
/retest |
kasiakepka
pushed a commit
to kasiakepka/test-infra
that referenced
this pull request
May 4, 2023
…yma-project#7127) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
muralov
pushed a commit
to muralov/test-infra
that referenced
this pull request
Jun 1, 2023
…yma-project#7127) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package
github.com/ghodss/yamlis no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml.The notable change is that
github.com/ghodss/yamlusesgopkg.in/yaml.v2 v2.2.2, butsigs.k8s.io/yamlusesgopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.Changes proposed in this pull request:
github.com/ghodss/yamldependencyRelated issue(s)