Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highest Lockup NaN HNS error when bidding ends #396

Closed
NetOpWibby opened this issue Jul 26, 2021 · 3 comments · Fixed by #458
Closed

Highest Lockup NaN HNS error when bidding ends #396

NetOpWibby opened this issue Jul 26, 2021 · 3 comments · Fixed by #458
Labels
bug Something isn't working

Comments

@NetOpWibby
Copy link
Contributor

Expected Behavior

I should see the highest lockup in number form.

Current Behavior

NaN shouldn't be displayed.

Steps to Reproduce

Not sure if the decimal has something to do with this error.

Screencap

SS 2021-07-26 at 11 22 08 AM
@rithvikvibhu
Copy link
Collaborator

I think this was fixed 1-2 releases ago. Is this the latest Bob (0.8.0)?

@NetOpWibby
Copy link
Contributor Author

Yup!

@rithvikvibhu
Copy link
Collaborator

Okay got the same issue on all REVEALing names with my bids that have won (not sure if this is the case for lost auctions too).

Highest Lockup is calculated with:

const highest = Math.max(bids.map(bid => bid.value));

so at least 1 bid.value isn't right.

Haven't tried reproducing in regtest, but the bids are:
image

  • All bids revealed (I revealed both first)
  • Half way through REVEAL currently

@rithvikvibhu rithvikvibhu added the bug Something isn't working label Feb 1, 2022
rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Feb 1, 2022
@rithvikvibhu
auction: fix NaN HNS lockup value (kyokan#396)
9c086a0 
Math.max takes elements as arguments, not 1 arg of elements array
@rithvikvibhu rithvikvibhu mentioned this issue Feb 1, 2022
Merged
rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Feb 6, 2022
@rithvikvibhu
auction: fix NaN HNS lockup value (kyokan#396)
d20c69a 
Math.max takes elements as arguments, not 1 arg of elements array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc fixes rithvikvibhu/bob-wallet
2 participants
@NetOpWibby @rithvikvibhu