wallet: add deepclean and wdb backup #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
reviewed
Mar 13, 2021
Comment on lines
+82
to
+84
| changeDepth: props.changeDepth, | ||
| receiveDepth: props.receiveDepth, | ||
| isUpdatingDepth: false, |
There was a problem hiding this comment.
Why do we need these in the state again?
pinheadmz
reviewed
Mar 13, 2021
| {this.renderSection( | ||
| 'Deep Clean and Rescan Wallet', | ||
| <div> | ||
| <div>For more information on deep clean, please see <Anchor href="https://github.com/handshake-org/hsd/blob/master/CHANGELOG.md#wallet-api-changes-1">here</Anchor></div> |
There was a problem hiding this comment.
This link may change as new versions get added to the hsd changelog -- I'm not sure a good static link to include here, maybe the PR? handshake-org/hsd#511
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
deepcleanandbackupto wallet setting view. Deep clean fixes many issues around rescan, and should allow Bob users to upgrade without removing wallet directory going forward.Also removed
updateAccountDepthfrom setting.