Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airdrop Claim #347

Merged
merged 7 commits into from
May 18, 2021
Merged

Airdrop Claim #347

merged 7 commits into from
May 18, 2021

Conversation

rithvikvibhu
Copy link
Collaborator

This PR adds a wizard to claim rewards from the airdrop by providing SSH/PGP keys. It's also possible to skip it and directly input the proof like before.

The file app/background/claim/airdrop.js is taken from the hs-airdrop repo, modified to export functions instead of as a cli script, and also pass along status updates.

A new ducks/claims handles logic for creating the proof, it can probably used for name claims also.

Screenshot of first screen only, not all:
image

@pinheadmz
Copy link
Contributor

hm, I'm uncomfortable with copying and pasting private keys, that seems super dangerous and clipboard contents may be accessible by other applications, even after the claim process is done. We already have enough issues in hs-airdrop by users who don't want to trust our software with their password. I think opening a file would be at least feel a little more secure.

@Falci
Copy link
Contributor

Falci commented May 10, 2021

Bob Wallet is an alternative. Not all users are that concerned with copy/paste keys, or they may have different levels of trust on their device/environment.
The way I see, it's hs-airdrop job to make it as much secure as it could be. Bob's job is to make it more user friendly.

That said, we could have both: paste or select file. We could also clear the clipboard area after use.

@rithvikvibhu
Copy link
Collaborator Author

I think opening a file would be at least feel a little more secure.

Will add a file select then. Will need to consider both armored and binary for pgp, but shouldn't be a problem.

About the clipboard clear, it's not really a bulletproof solution because there are clipboard managers that store a history - in both Windows (built-in) and Linux (kde at least).
Don't want to provide a false sense of sec and let people rely on that. We could add a text reminding them to clear it manually though.

@rithvikvibhu
Copy link
Collaborator Author

Added file selection, now handles ssh, pgp, asc, gpg files (hs-airdrop already does it well).

@chikeichan
Copy link
Contributor

Hey @rithvikvibhu ! Nice work 👍

I have made a PR against your branch here. Please review and let me know if you have any questions!

chikeichan and others added 2 commits May 18, 2021 13:24
 ux changes; surpress logging of private key
@rithvikvibhu
Copy link
Collaborator Author

Thanks, merged your changes

@chikeichan chikeichan merged commit 336baf1 into kyokan:master May 18, 2021
@rithvikvibhu rithvikvibhu deleted the airdrop-gui branch May 18, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants