yourBids: add filter by bid status #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLowe
suggested changes
Jun 13, 2021
app/pages/YourBids/index.js
Outdated
| const itemsPerPage = await dbClient.get(YOUR_BIDS_ITEMS_PER_PAGE_KEY); | ||
|
|
||
| console.log(this.props.match.params.filterType) |
|
@RobertLowe Are there any errors when running |
|
@rithvikvibhu nothing, it just hangs
|
|
dev loads
|
|
i was able to build successfully with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBidswill re-index every bids callingwallet.getNameStateByName. This limits network/rpc even locally, as even local rpc call is still a web request that adds overhead. I perf tested this with a wallet that has about 9k bid history on almost as many names, and the loading time with filter feels the same as loading time without filters.