Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screen msg for port conflict/other errors + misc #463

Merged
merged 2 commits into from
May 4, 2022
Merged

Splash screen msg for port conflict/other errors + misc #463

merged 2 commits into from
May 4, 2022

Conversation

rithvikvibhu
Copy link
Collaborator

@rithvikvibhu rithvikvibhu commented Feb 6, 2022 •
edited
Loading

After the wallet plugin refactor, splash screen stopped showing errors when node failed to start. That's fixed as well as:

  • Handled error for EADDRINUSE and replaced with message including ip and port
  • Removed dependency tcp-port-used
  • Re-ordered checks in ProtectedRoute to allow opening settings when no wallets exist
  • Removed unused imports

@pinheadmz
Copy link
Contributor

Screen Shot 2022-02-08 at 1 13 00 PM

Nice! I dont have the settings menu here though if i wanted to switch to remote rpc ?

@pinheadmz
Copy link
Contributor

Ok but i did see the settings button and was able to switch to remote rpc once bob was able to open (i.e. no port conflicts)

@pinheadmz
Copy link
Contributor

Screen Shot 2022-02-08 at 1 18 08 PM

Switching to SPV from this screen did lock up the app though. I had to restart it twice to get it to start syncing SPV. One thing that may be an issue swithcing from full node to SPV is the hosts.json file. I find that deleting this file gives the spv node a much better chance of finding supporting peers.

@rithvikvibhu rithvikvibhu mentioned this pull request Feb 10, 2022
Closed
@rithvikvibhu
Copy link
Collaborator Author

Nice! I dont have the settings menu here though if i wanted to switch to remote rpc ?

This PR is only for bringing back the error message in SplashScreen. master right now won't show any error and loads the login page with "No connection" in the header.

Following from the tg chat, it's not possible to:

  • open RPC settings because if there's an error on start, then the Router itself (and any page within) won't load
  • Even if you reach the custom RPC settings modal, wallet isn't init'ed and won't have network, so won't be able to connect to RPC.

Switching to SPV from this screen did lock up the app though. I had to restart it twice to get it to start syncing SPV.

Yeah this is a bug and happens even when toggling SPV mode normally from settings after logging in, opened issue #467.

@pinheadmz
Copy link
Contributor

OK cool, LGTM 👍 good to have that error back

@rithvikvibhu rithvikvibhu merged commit 34d6ea7 into kyokan:master May 4, 2022
@rithvikvibhu rithvikvibhu deleted the port-conflict branch May 4, 2022 07:45
Falci pushed a commit to Falci/bob-wallet that referenced this pull request Jun 22, 2022
@rithvikvibhu @Falci
Splash screen msg on port conflict (kyokan#463)
7f3e5d8 
- Handle error for EADDRINUSE and replaced with message including ip and port
- Remove dependency `tcp-port-used`
- Re-order checks in ProtectedRoute to allow opening settings when no wallets exist
- Remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinheadmz pinheadmz pinheadmz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rithvikvibhu @pinheadmz