Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the deserialization for LinkedHashMap generic for build hasher type #7

Merged
merged 2 commits into from
May 3, 2021

Conversation

robinbernon
Copy link
Contributor

Changing deserialization impl from LinkedHashMap<K, V> to LinkedHashMap<K, V, S>

Copy link

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @kyren This is worth merging. I implemented something similar on my hashlink fork.

@robinbernon Would you mind wasting a little time evaluating ritelinked? It is almost another hashlink, I did some simple optimization work.

@kyren
Copy link
Owner

kyren commented May 3, 2021

Yeah, I think this looks good to me, I apologize for waiting so long on some of these PRs, I have been trying to catch up.

if anyone would like to reach out to me to share maintainership of this crate that would be welcome, but I'll try to keep up with this stuff more closely.

@kyren kyren merged commit 9b42ad0 into kyren:master May 3, 2021
@kyren
Copy link
Owner

kyren commented May 3, 2021

I have also gone ahead and made the deserialize implementation on LinkedHashSet generic in the same way in 5daeea9.

@PsiACE
Copy link

PsiACE commented May 4, 2021

@kyren If you want, I can help maintain this crate/repo. I currently maintain a derivative version of hashlink, thank you very much for your work.

@kyren
Copy link
Owner

kyren commented May 4, 2021

@PsiACE that's very kind, actually let me think about this a bit more, if you could just keep reviewing PRs and commenting on / fixing issues then I'd feel comfortable adding you as a maintainer but I should probably do the responsible thing and only add people who have a bit of a history with the crate first? But I do appreciate the offer for help and you can still help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants