fix MssqlDialect streaming not handling backpressure.
#1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
changed the title
MssqlDialect streaming not handling backpressure.
igalklebanov
commented
Jun 16, 2024
igalklebanov
commented
Jun 16, 2024
igalklebanov
commented
Jun 16, 2024
|
Very helpful... thank you so much |
|
Very nice, in my tests this works 👍 |
github-merge-queue bot
referenced
this pull request
in dotkom/monoweb
Aug 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [kysely](https://togithub.com/kysely-org/kysely) | [`^0.26.3` -> `^0.27.0`](https://renovatebot.com/diffs/npm/kysely/0.26.3/0.27.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kysely-org/kysely (kysely)</summary> ### [`v0.27.4`](https://togithub.com/kysely-org/kysely/releases/tag/0.27.4) [Compare Source](https://togithub.com/kysely-org/kysely/compare/0.27.3...0.27.4) Hey 👋 We've reached 100 contributors AND 1,000 pull requests since our last release! 🍾 Here's all the amazing work done since version 0.27.3... #### 🚀 Features - Added `clearGroupBy()` by [@​dswbx](https://togithub.com/dswbx) in [https://github.com/kysely-org/kysely/pull/921](https://togithub.com/kysely-org/kysely/pull/921) - add `objectStrategy` option that allows to not mutate result objects/arrays @​ `ParseJSONResultsPlugin`. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/953](https://togithub.com/kysely-org/kysely/pull/953) ##### PostgreSQL 🐘 / SQLite 📘 - Support table names in UpdateQueryBuilder.returningAll by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@f63327e ##### MySQL 🐬 / MS SQL Server 🥅 - add varbinary data type for mysql by [@​jonasbovyn](https://togithub.com/jonasbovyn) in [https://github.com/kysely-org/kysely/pull/812](https://togithub.com/kysely-org/kysely/pull/812) ##### PostgreSQL 🐘 - feat: add 'add column if not exists' for postgres by [@​MarkusWendorf](https://togithub.com/MarkusWendorf) in [https://github.com/kysely-org/kysely/pull/900](https://togithub.com/kysely-org/kysely/pull/900) - feat: add '?|' comparison operator by [@​alenap93](https://togithub.com/alenap93) in [https://github.com/kysely-org/kysely/pull/1006](https://togithub.com/kysely-org/kysely/pull/1006) - feat: add the starts-with postgres comparison operator by [@​boehs](https://togithub.com/boehs) in [https://github.com/kysely-org/kysely/pull/1029](https://togithub.com/kysely-org/kysely/pull/1029) - postgres introspection getTables handle partition tables as well. by [@​HeikoOsigus](https://togithub.com/HeikoOsigus) in [https://github.com/kysely-org/kysely/pull/1034](https://togithub.com/kysely-org/kysely/pull/1034) ##### MS SQL Server 🥅 - add `OUTPUT` clause support. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/828](https://togithub.com/kysely-org/kysely/pull/828) #### 🐞 Bugfixes - move `preventAwait` to `alter-column-builder`.ts. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1031](https://togithub.com/kysely-org/kysely/pull/1031) - fixes The type of `eb` in `selectFrom(eb => ...)` is wrong by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@873671b - fixes QueryCompilerError: Could not serialize value causes Kysely instance to fail later by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@a65a7f3 - fixes CamelCasePlugin messes up complex type mappings with setTypeParser by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@d45a8fa ##### PostgreSQL 🐘 / MS SQL Server 🥅 - Updating visitMergeQuery to join `WhenNode`s with a space by [@​gittgott](https://togithub.com/gittgott) in [https://github.com/kysely-org/kysely/pull/940](https://togithub.com/kysely-org/kysely/pull/940) - fix merge queries not being transformed. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/955](https://togithub.com/kysely-org/kysely/pull/955) - fix `InferResult` not working for merge queries. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/902](https://togithub.com/kysely-org/kysely/pull/902) ##### PostgreSQL 🐘 - Fix typo on timetz regex by [@​dunkelbraun](https://togithub.com/dunkelbraun) in [https://github.com/kysely-org/kysely/pull/911](https://togithub.com/kysely-org/kysely/pull/911) ##### MS SQL Server 🥅 - fix `MssqlDialect` streaming not handling backpressure. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1041](https://togithub.com/kysely-org/kysely/pull/1041) - fix Tedious v18 includes different TypeScript annotations by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1041](https://togithub.com/kysely-org/kysely/pull/1041) - handle connection errors @​ `MssqlDriver`. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1042](https://togithub.com/kysely-org/kysely/pull/1042) #### 📖 Documentation - fix complex join example by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@9f836c4 - fix complex join example some more by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@8f9038f - fix complex insert example by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@ead3489 - improve subquery insert example by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@0e194b0 - add not null assertion site example by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@58ba4ae - fix a bunch of untyped sql snippets in API doc examples by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@64a56f9 - make it even more clear that table interfaces are not row types by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@9485b44 - update outdated intro in kysely.dev by [@​koskimas](https://togithub.com/koskimas) in kysely-org/kysely@e84863d - remove snyk badge. by [@​igalklebanov](https://togithub.com/igalklebanov) in kysely-org/kysely@4326a91 - add CTE examples to site by [@​koskimas](https://togithub.com/koskimas) in https://github.com/kysely-org/kysely/commit/d9a53cd1441e0854456e930eb628f5b03a34db93\\ - fix SQLite import @​ getting started. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/927](https://togithub.com/kysely-org/kysely/pull/927) - capitalization, more environments @​ README. by [@​igalklebanov](https://togithub.com/igalklebanov) in kysely-org/kysely@6ab2155 - fixed docs for deno by [@​kolay-v](https://togithub.com/kolay-v) in [https://github.com/kysely-org/kysely/pull/938](https://togithub.com/kysely-org/kysely/pull/938) - Added MySQL and MariaDB support information for relation recipes by [@​chriswep](https://togithub.com/chriswep) in [https://github.com/kysely-org/kysely/pull/800](https://togithub.com/kysely-org/kysely/pull/800) - Fix spelling, punctuation, grammar by [@​DePasqualeOrg](https://togithub.com/DePasqualeOrg) in [https://github.com/kysely-org/kysely/pull/969](https://togithub.com/kysely-org/kysely/pull/969) - Fix typo (it's --> its) by [@​davidalber](https://togithub.com/davidalber) in [https://github.com/kysely-org/kysely/pull/1000](https://togithub.com/kysely-org/kysely/pull/1000) - add logging documentation page by [@​JeromeBu](https://togithub.com/JeromeBu) in [https://github.com/kysely-org/kysely/pull/1003](https://togithub.com/kysely-org/kysely/pull/1003) - Docs now reflect `tedious` support in `Bun` by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1018](https://togithub.com/kysely-org/kysely/pull/1018) - Docs: Fix typo by [@​devgru](https://togithub.com/devgru) in [https://github.com/kysely-org/kysely/pull/1025](https://togithub.com/kysely-org/kysely/pull/1025) - mention `kysely-ctl` in migrations section. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1035](https://togithub.com/kysely-org/kysely/pull/1035) - docs: add comments for `UpdateResult` by [@​movahhedi](https://togithub.com/movahhedi) in [https://github.com/kysely-org/kysely/pull/993](https://togithub.com/kysely-org/kysely/pull/993) - fix mssql createPerson example. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1048](https://togithub.com/kysely-org/kysely/pull/1048) - docs: fix values example not compiling. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1058](https://togithub.com/kysely-org/kysely/pull/1058) - fix typo incorrect by [@​zce](https://togithub.com/zce) in [https://github.com/kysely-org/kysely/pull/1068](https://togithub.com/kysely-org/kysely/pull/1068) #### 📦 CICD & Tooling - migrate to docker compose v2. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/932](https://togithub.com/kysely-org/kysely/pull/932) - ci: bumping actions and runtimes. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/942](https://togithub.com/kysely-org/kysely/pull/942) - ci: drop node16 tests as it reached EOL. by [@​igalklebanov](https://togithub.com/igalklebanov) in kysely-org/kysely@873ed5a - remove docker-compose file version. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/966](https://togithub.com/kysely-org/kysely/pull/966) - add node22 @​ tests. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/964](https://togithub.com/kysely-org/kysely/pull/964) - export all operation nodes, forever. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/972](https://togithub.com/kysely-org/kysely/pull/972) - ci: bump bun, test mssql in bun. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1022](https://togithub.com/kysely-org/kysely/pull/1022) - ci: install only chromium by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1043](https://togithub.com/kysely-org/kysely/pull/1043) - bump TypeScript to v5.5. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/965](https://togithub.com/kysely-org/kysely/pull/965) - docs: bump docusaurus to v3. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1050](https://togithub.com/kysely-org/kysely/pull/1050) - docs: remove remaining react imports. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/1057](https://togithub.com/kysely-org/kysely/pull/1057) - ci: split jobs. by [@​igalklebanov](https://togithub.com/igalklebanov) in [https://github.com/kysely-org/kysely/pull/943](https://togithub.com/kysely-org/kysely/pull/943) ####⚠️ Breaking Changes #### 🐤 New Contributors - [@​dunkelbraun](https://togithub.com/dunkelbraun) made their first contribution in [https://github.com/kysely-org/kysely/pull/911](https://togithub.com/kysely-org/kysely/pull/911) - [@​dswbx](https://togithub.com/dswbx) made their first contribution in [https://github.com/kysely-org/kysely/pull/921](https://togithub.com/kysely-org/kysely/pull/921) - [@​kolay-v](https://togithub.com/kolay-v) made their first contribution in [https://github.com/kysely-org/kysely/pull/938](https://togithub.com/kysely-org/kysely/pull/938) - [@​chriswep](https://togithub.com/chriswep) made their first contribution in [https://github.com/kysely-org/kysely/pull/800](https://togithub.com/kysely-org/kysely/pull/800) - [@​jonasbovyn](https://togithub.com/jonasbovyn) made their first contribution in [https://github.com/kysely-org/kysely/pull/812](https://togithub.com/kysely-org/kysely/pull/812) - [@​DePasqualeOrg](https://togithub.com/DePasqualeOrg) made their first contribution in [https://github.com/kysely-org/kysely/pull/969](https://togithub.com/kysely-org/kysely/pull/969) - [@​davidalber](https://togithub.com/davidalber) made their first contribution in [https://github.com/kysely-org/kysely/pull/1000](https://togithub.com/kysely-org/kysely/pull/1000) - [@​JeromeBu](https://togithub.com/JeromeBu) made their first contribution in [https://github.com/kysely-org/kysely/pull/1003](https://togithub.com/kysely-org/kysely/pull/1003) - [@​alenap93](https://togithub.com/alenap93) made their first contribution in [https://github.com/kysely-org/kysely/pull/1006](https://togithub.com/kysely-org/kysely/pull/1006) - [@​devgru](https://togithub.com/devgru) made their first contribution in [https://github.com/kysely-org/kysely/pull/1025](https://togithub.com/kysely-org/kysely/pull/1025) - [@​boehs](https://togithub.com/boehs) made their first contribution in [https://github.com/kysely-org/kysely/pull/1029](https://togithub.com/kysely-org/kysely/pull/1029) - [@​HeikoOsigus](https://togithub.com/HeikoOsigus) made their first contribution in [https://github.com/kysely-org/kysely/pull/1034](https://togithub.com/kysely-org/kysely/pull/1034) - [@​movahhedi](https://togithub.com/movahhedi) made their first contribution in [https://github.com/kysely-org/kysely/pull/993](https://togithub.com/kysely-org/kysely/pull/993) - [@​zce](https://togithub.com/zce) made their first contribution in [https://github.com/kysely-org/kysely/pull/1068](https://togithub.com/kysely-org/kysely/pull/1068) **Full Changelog**: kysely-org/kysely@0.27.3...0.27.4 ### [`v0.27.3`](https://togithub.com/kysely-org/kysely/compare/0.27.2...0.27.3) [Compare Source](https://togithub.com/kysely-org/kysely/compare/0.27.2...0.27.3) ### [`v0.27.2`](https://togithub.com/kysely-org/kysely/releases/tag/0.27.2) [Compare Source](https://togithub.com/kysely-org/kysely/compare/0.27.1...0.27.2) - Add `allowUnorderedMigrations` option for the migrator. [#​723](https://togithub.com/kysely-org/kysely/issues/723) Awesome work by [@​tracehelms](https://togithub.com/tracehelms) ❤️ - Fix update and insert query type issues when using `Kysely<any>`. - Improve error messages when passing a wrong column name or wrong type for a column in `UpdateQueryBuilder#set` and `InsertQueryBuilder#values` methods. ### [`v0.27.1`](https://togithub.com/kysely-org/kysely/releases/tag/0.27.1) [Compare Source](https://togithub.com/kysely-org/kysely/compare/0.27.0...0.27.1) - [Add `$notNull` type helper](https://togithub.com/kysely-org/kysely/commit/ad194e1aa15e014d0aea3009039b8caa6ef92767) - Support `for update of table` and friends [#​683](https://togithub.com/kysely-org/kysely/issues/683) - Support `insert into "person" default values` [#​685](https://togithub.com/kysely-org/kysely/issues/685) - Support arbitrary expressions in `limit` and `offset` - Support insert, update and delete queries in raw SQL substitutions [#​680](https://togithub.com/kysely-org/kysely/issues/680) - Fix node 14 regression [#​824](https://togithub.com/kysely-org/kysely/issues/824) - Fix `fn.agg` regression where two type arguments were required [#​829](https://togithub.com/kysely-org/kysely/issues/829) ### [`v0.27.0`](https://togithub.com/kysely-org/kysely/releases/tag/0.27.0) [Compare Source](https://togithub.com/kysely-org/kysely/compare/0.26.3...0.27.0) - Add mssql dialect. A huge effort by [@​igalklebanov](https://togithub.com/igalklebanov) ❤️ [#​595](https://togithub.com/kysely-org/kysely/issues/595) - Add postgres `json_agg` and `to_json` functions to function module - Add `is distinct from` operator [#​673](https://togithub.com/kysely-org/kysely/issues/673) - Add `set('first_name', 'Jennifer')` variant for update query's `set` method [#​672](https://togithub.com/kysely-org/kysely/issues/672) - Add `as` statement support for createTable [#​771](https://togithub.com/kysely-org/kysely/issues/771). Thank you [@​viraxslot](https://togithub.com/viraxslot) ❤️ - Add `nulls not distinct` option for constraints [#​770](https://togithub.com/kysely-org/kysely/issues/770). Thank you [@​viraxslot](https://togithub.com/viraxslot) ❤️ - Add `addIndex` & `dropIndex` @​ AlterTableBuilder [#​720](https://togithub.com/kysely-org/kysely/issues/720). Thank you [@​Gaspero](https://togithub.com/Gaspero) - Add `stream()` support for sqlite dialect [#​754](https://togithub.com/kysely-org/kysely/issues/754). Thank you [@​tgriesser](https://togithub.com/tgriesser) ❤️ - Fix query and error logging both occur on error. [#​796](https://togithub.com/kysely-org/kysely/issues/796). Thank you [@​igalklebanov](https://togithub.com/igalklebanov) ❤️ - Fix type issue with `$if` [#​793](https://togithub.com/kysely-org/kysely/issues/793). Thank you [@​igalklebanov](https://togithub.com/igalklebanov) ❤️ - Fix issue where `onConflict..doUpdateSet` used select types instead of update types. [#​792](https://togithub.com/kysely-org/kysely/issues/792). Thank you [@​igalklebanov](https://togithub.com/igalklebanov) ❤️ - Add `eb.jsonPath<$>` [#​791](https://togithub.com/kysely-org/kysely/issues/791). Thank you [@​igalklebanov](https://togithub.com/igalklebanov) ❤️ - `$narrowType` [supports new type tag `NotNull`](https://togithub.com/kysely-org/kysely/commit/ad3ee2b0fdb5ed2c55635b1e03b7b09406f12e6b) for an easier way to mark columns not nullable manually - Fix [#​811](https://togithub.com/kysely-org/kysely/issues/811) - Support arbitrary expressions in `min` and `max` aggregate functions. ##### Breaking changes - `selectNoFrom` is removed from `ExpressionBuilder` due to severe typescript performance issues. `selectNoFrom` still exists in the `Kysely` instance, and in most cases, you can use that instead. See this example on how to migrate: https://kyse.link/?p=s\&i=sqAZIvTQktxgXYzHGkqX. - Types are once again a little bit stricter in some places. You might get type errors from code like ``where('first_name', '=', sql`something`)``. You need to explicitly give a type for the `sql` expressions like this `` sql<string>`something` `` - Deprecated functions `eb.cmpr` and `eb.bxp` have been removed. Use `eb` as a function instead. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dotkom/monoweb). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
thecodrr
pushed a commit
to thecodrr/kysely
that referenced
this pull request
Sep 3, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #879.
fixes #971.
Now MSSQL driver handles backpressure properly using
tedious'spauseandresumemethods.Also aligns the dialect's types with
tediousnewly exported types.