InferResult should output plural.
#1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix merge query results not be inferred. remove debug noise.
igalklebanov
added
breaking change
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
koskimas
approved these changes
Jul 5, 2024
igalklebanov
added a commit
that referenced
this pull request
Jul 7, 2024
koskimas
pushed a commit
that referenced
this pull request
Jul 16, 2024
koskimas
pushed a commit
that referenced
this pull request
Jul 19, 2024
igalklebanov
added a commit
that referenced
this pull request
Aug 25, 2024
igalklebanov
added a commit
that referenced
this pull request
Aug 25, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 3, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 3, 2024
igalklebanov
added a commit
to igalklebanov/kysely
that referenced
this pull request
Oct 4, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 12, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 19, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 24, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 24, 2024
igalklebanov
added a commit
that referenced
this pull request
Oct 27, 2024
igalklebanov
added a commit
that referenced
this pull request
Nov 2, 2024
igalklebanov
added a commit
that referenced
this pull request
Nov 24, 2024
igalklebanov
added a commit
that referenced
this pull request
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Right now,
InferResultwrongfully outputs a singular type, despite queries actually having a plural result type when executed.This PR makes it plural instead.
This will enable simpler types for when we implement batch execution.