fix(inserts): resolve issues with undefined values

[naorpeled]

closes #1310

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 5, 2025 9:05pm

[pkg-pr-new]

Open in Stackblitz • kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1311

commit: 15bcf77

[koskimas]

Looking good otheriwse but: when inserting a single row, the value should actually be missing and not DEFAULT. The change now caused DEFAULT being used even when you insert a single row with an undefined value (see all the failing tests).

Most databases support DEFAULT but not all. For example on sqlite we need to use null instead. Mapping undefined to null is not a good idea when it can be avoided.

[naorpeled]

Looking good otheriwse but: when inserting a single row, the value should actually be missing and not DEFAULT. The change now caused DEFAULT being used even when you insert a single row with an undefined value (see all the failing tests).

Most databases support DEFAULT but not all. For example on sqlite we need to use null instead. Mapping undefined to null is not a good idea when it can be avoided.

Makes sense,
how would you separate those two cases in the cleanest way?

[koskimas]

how would you separate those two cases in the cleanest way?

Don't know. Maybe just a special case when rows.length === 1? Add a comment why the special case is there in case you end up with this solution.