fix onConflict compilation errors since TS 5.1.6.
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think I wrongfully removed unused generics from do nothing builder. Will add them back once power outtage is over. |
koskimas
approved these changes
Jul 7, 2023
Gaspero
pushed a commit
to Gaspero/kysely
that referenced
this pull request
Oct 2, 2023
* fix compilation errors since 5.1.6. * rollback OnConflictDoNothing generics removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #567.
Seems like a bug in both TypeScript (up to 5.1.3) and in our codebase. We provided an expected return type that can never be matched by call site, and TypeScript never yelled.
And looks like they fixed it in 5.1.6?? 🤷
.doUpdateSetreturn type:vs.
.onConflict'scallbackargument's return type: