fix: WithSchemaPlugin is adding schema to function arguments and causes db errors.
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
force-pushed
the
fix-schema-added-yet-not-allowed
branch
from
5865561 to
5dbaee4
Compare
igalklebanov
force-pushed
the
fix-schema-added-yet-not-allowed
branch
from
5dbaee4 to
bb86fad
Compare
igalklebanov
force-pushed
the
fix-schema-added-yet-not-allowed
branch
from
bb86fad to
706a428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Recently we've added
eb.fn.jsonAggandeb.fn.toJson. Both accept table names orsql.table/eb.tableas arguments.WithSchemaPluginadds schema names to the arguments, resulting in DB errors.This makes the plugin not usable anytime such functions are used, which is quite an annoyance.
This PR makes sure the plugin leaves
TableNodes in specific functions' (currently we know ofjsonAggandtoJsonbut there might be more) arguments as-is (no schema is added).