Add orderBy clause support to aggregate function builder

[ivashog]

#780

see sql syntax on PostgreSQL example: https://www.postgresql.org/docs/16/sql-expressions.html#SYNTAX-AGGREGATES

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 8:19pm

[igalklebanov]

Hey 👋

Thanks! 💪

This is also supported in MySQL and SQLite for some aggregate functions. Let's add tests for those.

[ivashog]

Hey

Thanks, @igalklebanov

I follow your recommendation and add a separate test case for order-sensitive aggregate functions including mysql and sqlite.

Also I explore this functionality in mssql and discovered that we need implement within group (order by ...) clause support for aggregate functions - #781. But it is better to implement it in a separate PR, what do you say?

[igalklebanov]

But it is better to implement it in a separate PR, what do you say?

Yeah, different clause, different PR.

[igalklebanov]

Looks good and functional overall! 💪

Left a few minor suggestions, once addressed this is good to go! 🚀

[ivashog]

Looks good and functional overall! 💪

Left a few minor suggestions, once addressed this is good to go! 🚀

@igalklebanov, thanks for review!

[igalklebanov]

LGTM! 🚀

[juusaw]

Any plans to release this feature? It would be really useful for us.