fix(verifier): give more useful diagnostics during recovery #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might want to consider continuing recovery after lowering fails. In practice this happens when a program with inspections is partially lowered (because the full program can't be solved) and some inspected evars never appear, so are never given types. Note that we'll also need to fix the output record/expression as those datalog variables will be unconstrained. This PR does a simpler thing and cleans up errors during recovery (to clarify that the 'no type found for X' messages are expected); it also selects a more relevant error goal.
jaysachs
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to consider continuing recovery after lowering fails. In practice this happens when a program with inspections is partially lowered (because the full program can't be solved) and some inspected evars never appear, so are never given types. Note that we'll also need to fix the output record/expression as those datalog variables will be unconstrained.
This PR does a simpler thing and cleans up errors during recovery (to clarify that the 'no type found for X' messages are expected); it also selects a more relevant error goal.