Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericMessage.unpack should unpack the whole struct, not only its body #54

Open
ajoaoff opened this issue Jun 28, 2021 · 0 comments
Open

GenericMessage.unpack should unpack the whole struct, not only its body #54

ajoaoff opened this issue Jun 28, 2021 · 0 comments

Comments

@ajoaoff
Copy link

ajoaoff commented Jun 28, 2021

Original issue opened by @erickvermot at kytos#407.

All the GenericStruct unpacks the whole struct.
Making GenericMessage only unpack the body makes one structure 'protocol' different from the other, for no reason...

PacketIn.unpack() method should be able to unpack the whole message for ex.

I have this ready, and I can make a PR as soon as the changes I've introduced in recent PRs are accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajoaoff