Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

GenericMessage.unpack should unpack the whole struct, not only its body #407

Open
erickvermot opened this issue Jul 13, 2017 · 1 comment

Comments

@erickvermot
Copy link
Contributor

All the GenericStruct unpacks the whole struct.
Making GenericMessage only unpack the body makes one structure 'protocol' different from the other, for no reason...

PacketIn.unpack() method should be able to unpack the whole message for ex.

I have this ready, and I can make a PR as soon as the changes I've introduced in recent PRs are accepted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant