submitの際のコマンド実行を追加 #234
Merged
submitの際のコマンド実行を追加 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stable #234 +/- ##
==========================================
+ Coverage 89.73% 90.49% +0.75%
==========================================
Files 62 63 +1
Lines 2612 2651 +39
==========================================
+ Hits 2344 2399 +55
+ Misses 268 252 -16
Continue to review full report at Codecov.
|
atcodertools/tools/submit.py
Outdated
| if config.submit_config.exec_before_submit: | ||
| run_command(config.submit_config.exec_before_submit, "./") | ||
| if not config.submit_config.submit_filename: | ||
| print("submit_filename is not specified") |
There was a problem hiding this comment.
他のコードみたいにprintではなくlogger使ってくれると統一性とか出力のコントロールが出来て出て嬉しいです。多分errorですかね
atcodertools/tools/submit.py
Outdated
| print("submit_filename is not specified") | ||
| return False | ||
| code_path = config.submit_config.submit_filename | ||
| print("changed to submitfile: ", code_path) |
There was a problem hiding this comment.
logger.info(f"Submit file path overriding happened. new submit file path: {code_path}")とかがいいかなと思います。
|
主にlog周りでコメントしました。
このあたりが実際にconfigにある状態でsubmitを走らせたらちゃんと正しく動くかどうかのテストって追加できませんか? |
|
よさそうです!!!!!!!!!!!! |
kyuridenamida
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACLなどでexpanderを実行してからsubmitできるようにしました。exec_before_submit, exec_after_submit, submit_filenameをconfigのsubmitで指定し、以下の機能があります。