Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setterを追加 #249

Merged
merged 5 commits into from
Nov 29, 2021
Merged

setterを追加 #249

merged 5 commits into from
Nov 29, 2021

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Nov 18, 2021

1.1.7.1にあったsetterを移植しました。

機能は以下です。

  1. atcoder-tools set --lang nimなどと言語を変更できる(この場合Nim言語に変更)。codegenがもう一度動き該当の言語のテンプレートが作成される。以降、test, submitは変更した言語で行われる。
  2. atcoder-tools set --judge-type absolute_or_relativeなどとjudge-typeを変更できる
  3. atcoder-tools set --error-value 1e-9などと許容誤差を変更できる

1.は途中で言語を変更したくなったとき、2.と3.はcodegenで誤差ジャッジを検出できなかったときに行うことを想定しています。
judge-typeは複数解、インタラクティブもあったのですが、まだ移植できていないので削除しました。

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #249 (4faa481) into stable (da56d3b) will decrease coverage by 0.15%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #249      +/-   ##
==========================================
- Coverage   90.49%   90.33%   -0.16%     
==========================================
  Files          63       64       +1     
  Lines        2652     2712      +60     
==========================================
+ Hits         2400     2450      +50     
- Misses        252      262      +10     
Impacted Files Coverage Δ
atcodertools/atcoder_tools.py 0.00% <0.00%> (ø)
atcodertools/tools/setter.py 75.47% <75.47%> (ø)
atcodertools/client/atcoder.py 90.00% <100.00%> (ø)
atcodertools/common/judgetype.py 93.75% <100.00%> (+5.22%) ⬆️
atcodertools/release_management/version.py 100.00% <100.00%> (ø)
atcodertools/tools/codegen.py 77.55% <100.00%> (ø)
atcodertools/tools/envgen.py 85.14% <0.00%> (+1.14%) ⬆️
atcodertools/tools/models/metadata.py 97.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ca6f8...4faa481. Read the comment docs.

@kyuridenamida kyuridenamida modified the milestones: 2.10.0, 2.11.0 Nov 28, 2021
@kyuridenamida
Copy link
Owner

ありがとうございます。また気が向いたときにREADMEにsetterについての説明を書くと喜ばれると思いますがひとまずマージします!

@kyuridenamida
Copy link
Owner

便利機能をありがとうございます!

@kyuridenamida kyuridenamida merged commit ee5c6ee into kyuridenamida:stable Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants