Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for 'serve' command flags #579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test for 'serve' command flags #579

wants to merge 1 commit into from

Conversation

Veer0x1
Copy link

@Veer0x1 Veer0x1 commented Dec 12, 2024

Explanation

This PR adds test coverage for command flags in the serve package. It validates both default values and user-defined values for server configuration flags including host, port, gin mode, logging, CORS, and max body size settings.

Related issue

#22

Milestone of this PR

/milestone 0.3.0

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .

@Veer0x1
Copy link
Author

Veer0x1 commented Dec 21, 2024

@JimBugwadia can you review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Veer0x1