fix: image verify cache test #8462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
vishal-chdhry
requested review from
MarcelMue,
realshuting and
MariamFahmy98
as code owners
|
Needs label/milestone |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #8462 +/- ##
=======================================
Coverage 35.54% 35.54%
=======================================
Files 309 309
Lines 24996 24996
=======================================
Hits 8885 8885
Misses 15220 15220
Partials 891 891 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
eddycharly
approved these changes
Sep 20, 2023
|
/cherry-pick release-1.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
* fix: image verify cache test Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * feat: print err message Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * feat: clear mock Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * feat: defer clear mock Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> --------- Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
added
the
cherry-pick-completed
eddycharly
added a commit
that referenced
this pull request
Sep 20, 2023
* fix: image verify cache test * feat: print err message * feat: clear mock * feat: defer clear mock --------- Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> Co-authored-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes image verify cache tests