Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Домашнее задание Гликин Сергей #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sglikin
Copy link

@Sglikin Sglikin commented Mar 31, 2024

No description provided.

Copy link

@a-poliakov a-poliakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -39,21 +39,15 @@ resource "yandex_mdb_clickhouse_cluster" "clickhouse_starschema" {
timezone = "UTC"
geobase_uri = ""
query_log_retention_size = 1073741824
query_log_retention_time = 2592000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

параметры развертывания могут меняться, это нормально

@@ -0,0 +1,4 @@
packages:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

служебный файлик, должен быть в gitignore

port: 8443
user: "{{ env_var('DBT_USER') }}"
password: "{{ env_var('DBT_PASSWORD') }}"
user: "admin"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

логины-пароли лучше не коммитить в общий доступ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants