Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with angular-translate #99

Closed
l-lin opened this issue Oct 16, 2014 · 1 comment
Closed

Integration with angular-translate #99

l-lin opened this issue Oct 16, 2014 · 1 comment
Labels
enhancement
Milestone
v0.3.1

Comments

@l-lin
Copy link
Owner

l-lin commented Oct 16, 2014

Angular-translate's $translate service behaves asynchronously and returns a promise. So it's not possible to define the title of the columns with this module. Indeed, the functions DTColumn.withTitle and DTColumnDef.withTitle expect a String as a parameter.
@MaximeFrancoeur
Copy link

+1

@l-lin l-lin added this to the v0.3.1 milestone Dec 21, 2014
l-lin added a commit that referenced this issue Dec 29, 2014
@l-lin
Integration with angular-translate #99
89d5bc6 
* Resolve all promises before rendering
@l-lin l-lin closed this as completed Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.3.1
Development

No branches or pull requests
2 participants
@l-lin @MaximeFrancoeur