Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an id property, this new property will be used as unique to in… #1750

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

dlascarez
Copy link
Contributor

Create an ID property, this new property will be used as unique to identify each column instead of "data".
This change will fix the error:

#1748

Copy link
Collaborator

@shanmukhateja shanmukhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback

src/models/settings.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/angular-datatables.directive.ts Outdated Show resolved Hide resolved
src/models/settings.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@shanmukhateja shanmukhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Need to wait for Louis's review to merge.

@l-lin l-lin merged commit 605015e into l-lin:master Sep 22, 2023
1 check passed
@dlascarez dlascarez deleted the bug/BUG-1748 branch September 22, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants