Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump wgpu dependency to 23.0 #187

Merged
merged 1 commit into from
Dec 4, 2024
Merged

bump wgpu dependency to 23.0 #187

merged 1 commit into from
Dec 4, 2024

Conversation

KolCrooks
Copy link

@KolCrooks KolCrooks commented Dec 4, 2024

Currently, you use two versions of wgpu (22.0 and 23.0), causing this issue:

error[E0308]: arguments to this method are incorrect
    --> src/camera.rs:415:21
     |
415  |         self.device.frame_texture(device, queue, label)
     |                     ^^^^^^^^^^^^^ ------  ----- expected `wgpu::api::queue::Queue`, found `wgpu::Queue`
     |                                   |
     |                                   expected `wgpu::api::device::Device`, found `wgpu::Device`

This PR bumps the 22.0 to 23.0, fixing the error.

I don't completely understand the project structure so I could be wrong here, but using workspace dependencies might be good in this case to make sure all the dependencies are synchronized. I appreciate the work that you've put into this library :-)

@l1npengtul
Copy link
Owner

oops mustve missed this during testing
ill merge this and put out 10.7

@l1npengtul l1npengtul merged commit 59ee276 into l1npengtul:0.10 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants