-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1
Develop #1
Conversation
Hi, Michael! |
Hi,
Yes I absolutely need to write tests, haven't got that far with Go yet. I
also haven't implemented the Async calls as I have no experience with that
yet. I initiated the pull request to message you mostly as I am
implementing this for a commercial project and the FINS aspect is tiny, so
I may not have time to continue until next year. I do intend to implement
tests soon.
I mostly use Beckhoff TwinCAT systems so I will be looking at a driver for
that soon too.
Hope it was of assistance and that n you for the initial library, it helped
me learn Go!
…On Wed, 11 Jul. 2018, 8:43 pm l1va, ***@***.***> wrote:
Hi, Michael!
First of all thank you for your contribution!
As you see i have not so big experience with fins and have done only part
that i was needed.
Do not afraid of your Go, it is good.
I have only two big questions to the pull-request: 1. I do not see how
async calls will be implemented. You fixed logic that answer should be
always and i think it will be difficult to change in future.
2. Tests. I would like to have at least one test for each flow.
And give me more time please to read more carefully for other small
comments.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AlpY2_iayuKilYSCDov6VSH4TQtTi78-ks5uFda7gaJpZM4VH4BN>
.
|
Hi, Mike, do you have telegramm or any other messanger? I have some question, maybe you can help. Thanks! My telegramm is @l1va4ka . |
Hi, I have been working a lot with Omron FINS, initially with Java but am now learning Go. My use is for a commercial product and things seem to be working well.
I don't really know much about Go yet, in terms of conventions or proper program structure, but hopefully what I have done might be of assistance. I have got 99% of the static stuff, like command codes, end codes etc all working. I have also removed a lot of the implementation details from the Frame, Header, Command and Response objects, and moved that into the encode/decode methods. This is a very typical Java way of doing this and may not be appropriate for Go.
Anyway, I hope this is of use and watch out for more commits from me coming.