Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] dev from opf:dev #163

Merged
merged 111 commits into from
Apr 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
39bb849
Correct toolbar height for calculation of the table height. Otherwise…
HDinger Apr 12, 2024
5324e36
Replace the dropdown menu in the projects list with a Primer::Alpha::…
HDinger Apr 12, 2024
ab55c76
Remove special hack for projects list, as it is not needed any more
HDinger Apr 15, 2024
a38cbad
[#52155] Duplicate scrollbars on project list page when opening the f…
dominic-braeunlein Jan 29, 2024
9441046
add an icon for any toast, so you can pass any iocn to the toast but …
bsatarnejad Apr 15, 2024
c18d839
make the icon in info toast blue
bsatarnejad Apr 15, 2024
301a524
use bell icon in notification center
bsatarnejad Apr 15, 2024
ec27a38
Add a placeholder icon in front of the responsible autocompleter of a…
HDinger Apr 15, 2024
3a73b1c
set the correct color for success, warning and errors toasts whenever…
bsatarnejad Apr 15, 2024
6dd813d
[#53069] bump xeokit bim viewer version to 2.5.1
Kharonus Mar 4, 2024
8e8ce33
[#53069] project xeokit bcf viewpoint to bcf api compliant data
Kharonus Mar 18, 2024
858bb5c
[#53069] added measurement tool toggle
Kharonus Apr 12, 2024
44fe1c7
[#53069] disabled measurement tools
Kharonus Apr 16, 2024
8234537
[#53344] Navigate to the default query page when other users query ha…
dombesz Apr 15, 2024
45e5cb0
Added retry_on handling to ManageNextcloudIntegrationJob
Apr 16, 2024
35ce469
Remove duplicate filters in BaseQuery#where
oliverguenther Apr 16, 2024
ae23279
Merge pull request #15252 from opf/40147-snackbar-toast-informing-use…
HDinger Apr 17, 2024
026f6c2
[54290] Superflous drop-down arrow on %Complete input modal (#15272)
bsatarnejad Apr 17, 2024
3e5d6e9
Restore drop down arrow for simple select fields
cbliard Apr 17, 2024
298ef05
remove unused i18n key
ulferts Apr 17, 2024
32bfc1d
Merge pull request #15279 from opf/bug/54046-outbound-requests-dont-r…
Apr 17, 2024
4ebdafc
set the correct css selector for styles of an arrow in select
bsatarnejad Apr 17, 2024
ffa88df
Merge pull request #15289 from opf/fix-showing-arrows-in-general-select
ulferts Apr 17, 2024
2ece919
replace teaser image
ulferts Apr 17, 2024
27ee3ca
[54309] Display total work even when set to 0h
cbliard Apr 17, 2024
1707df6
Center modals and dialogs per default except for the sharing modal wh…
HDinger Apr 17, 2024
d15b7f9
Merge pull request #15292 from opf/bug/54309-totals-with-0h-should-be…
ulferts Apr 17, 2024
d4d14a4
Merge pull request #15294 from opf/bug/54307-show-dialogs-in-the-cent…
HDinger Apr 17, 2024
4bbb232
Merge pull request #15254 from opf/bug/53977-meeting-fix-ui-issues-ar…
HDinger Apr 17, 2024
734a276
[54299] Total values are unset for work packages without any children
cbliard Apr 17, 2024
b275cb9
Merge pull request #15287 from opf/bug/54299-non-parent-work-package-…
cbliard Apr 17, 2024
7a9a43f
Rename openproject/community to openproject/openproject
oliverguenther Apr 16, 2024
5365310
Add release notes entry
oliverguenther Apr 16, 2024
cc0c6f2
Merge pull request #15269 from opf/chore/rename-docker-image
oliverguenther Apr 17, 2024
07e1337
Move autolinking before relative link filter and fix link to agenda i…
oliverguenther Apr 17, 2024
479cb7c
[54308] Make rounding consistent with 2 decimals in progress modal
cbliard Apr 17, 2024
3c4d84d
[fix] replace xeokit toolbar icons with octicons
Kharonus Apr 17, 2024
7bc75fe
update teaser image
ulferts Apr 17, 2024
2389e8d
[#54127] Language in Email notifications subscribe section UI inconcl…
ba1ash Apr 15, 2024
573f250
Merge pull request #15302 from opf/bug/54127-language-in-email-notifi…
ba1ash Apr 17, 2024
9bc69c9
update locales from crowdin [ci skip]
openprojectci Apr 18, 2024
c13dde4
update locales from crowdin [ci skip]
openprojectci Apr 18, 2024
53afc0a
build(deps): bump appsignal from 3.6.4 to 3.6.5
dependabot[bot] Apr 18, 2024
55ccbb9
Merge pull request #15306 from opf/dependabot/bundler/dev/appsignal-3…
klaustopher Apr 18, 2024
fb293ea
Merge pull request #15300 from opf/bug/54308-rounding-should-be-consi…
cbliard Apr 18, 2024
2537dc5
Merge branch 'dev' into fix/duplicate-filters
klaustopher Apr 18, 2024
5a42819
Remove hack to have unique filter count
klaustopher Apr 18, 2024
450862c
Fix meeting being an attachable resource
oliverguenther Apr 18, 2024
bcbe047
build(deps): bump aws-sdk-s3 from 1.146.1 to 1.147.0
dependabot[bot] Apr 18, 2024
ba4ddbb
Merge pull request #15281 from opf/fix/duplicate-filters
klaustopher Apr 18, 2024
d6d708e
Merge pull request #15308 from opf/dependabot/bundler/dev/aws-sdk-s3-…
klaustopher Apr 18, 2024
968b6ff
build(deps): bump view_component from 3.12.0 to 3.12.1
dependabot[bot] Apr 18, 2024
eb4a6f7
[54310] Fix remaining work exceeding work when rounding
cbliard Apr 18, 2024
a34146b
Merge remote-tracking branch 'origin/release/14.0' into dev
oliverguenther Apr 18, 2024
c12b3af
[fix] insert xeokit icons only once
Kharonus Apr 18, 2024
7858e82
Use openprojectci token
oliverguenther Apr 18, 2024
2e772ac
build(deps): bump the angular group in /frontend with 13 updates
dependabot[bot] Apr 18, 2024
ad1a644
Fix spacing issues on the progress drop-modal which occured because o…
HDinger Apr 18, 2024
16122c1
Bump appsignal
oliverguenther Apr 15, 2024
6b83c89
Bump fullcalendar
oliverguenther Apr 15, 2024
8d3f61f
Bump turbo
oliverguenther Apr 15, 2024
2c49b5d
Bump ng-select
oliverguenther Apr 15, 2024
6c328e5
Bump moment
oliverguenther Apr 15, 2024
005c810
Bump dragula and ng2-dragula
oliverguenther Apr 15, 2024
8c58b6d
Bump stimulus-use
oliverguenther Apr 15, 2024
4470076
Don't subscribe to subsequent updates of the work_package model auth
oliverguenther Mar 18, 2024
34c77bc
Update frontend/src/app/features/work-packages/components/wp-buttons/…
oliverguenther Apr 15, 2024
3fc29be
[#53069] bump to 2.5.1-beta-28
Kharonus Apr 18, 2024
4bbbfa2
Merge branch 'release/14.0' into dev
openprojectci Apr 18, 2024
d666ec0
Merge pull request #14907 from opf/bim/53069-update-xeokit-bim-viewer…
Kharonus Apr 18, 2024
51f684f
Bug/52098 misleading error message when ifc upload file size exceeds …
akabiru Apr 18, 2024
aa0e905
Merge pull request #15301 from opf/fix/octicons-bim-viewer
Kharonus Apr 18, 2024
61fe67a
Backfill presenter from author
oliverguenther Apr 18, 2024
b0490a3
Let table grow because it would otherwise not span the complete width…
HDinger Apr 18, 2024
eec9dc8
Merge pull request #15266 from opf/bump/npm-deps
oliverguenther Apr 18, 2024
134a1d2
build(deps): bump @openproject/octicons-angular in /frontend
dependabot[bot] Apr 18, 2024
71de829
The split field should only span the complete width in the table to e…
HDinger Apr 18, 2024
2060d6b
Merge pull request #15237 from opf/bug/54137-doubled-scrollbar-and-we…
HDinger Apr 18, 2024
cb27d91
Rendering single names without spaces without repeating the first letter
oliverguenther Apr 18, 2024
67df322
Round progress values to 2 decimals
cbliard Apr 18, 2024
5c9220c
Merge pull request #15024 from opf/fix/49136/create-button-disabled
dombesz Apr 18, 2024
9436efa
Merge pull request #15311 from opf/bug/54310-rounding-should-not-make…
aaron-contreras Apr 18, 2024
95d4e5d
update locales from crowdin [ci skip]
openprojectci Apr 19, 2024
c8c0c62
update locales from crowdin [ci skip]
openprojectci Apr 19, 2024
61b1c9f
[54288] wording is off for progress calculation input errors (#15290)
bsatarnejad Apr 19, 2024
9308118
build(deps): bump aws-sdk-core from 3.192.0 to 3.192.1
dependabot[bot] Apr 19, 2024
2078fe6
Left align the progress modal per default to avoid that users have to…
HDinger Apr 19, 2024
ad167ff
Update preview example to new html structure
HDinger Apr 19, 2024
86ef855
Reset sticky toolbars for editors inside Dialogs to avoid overlapping…
HDinger Apr 19, 2024
598672d
Merge pull request #15320 from opf/bug/53724-ckeditor-paragraph-toolb…
dombesz Apr 19, 2024
e36cce2
Merge pull request #15304 from opf/dependabot/bundler/dev/view_compon…
ulferts Apr 19, 2024
f6bba4f
Merge pull request #15307 from opf/dependabot/npm_and_yarn/frontend/d…
ulferts Apr 19, 2024
30e3b13
Merge pull request #15318 from opf/dependabot/bundler/dev/aws-sdk-cor…
ulferts Apr 19, 2024
e9890b3
Merge remote-tracking branch 'origin/release/14.0' into dev
ulferts Apr 19, 2024
47c725b
Merge pull request #15258 from opf/bug/53344-cannot-modify-a-query-th…
cbliard Apr 19, 2024
476e5d6
Do not swallow error if work is not a number
cbliard Apr 19, 2024
c248a84
Merge pull request #15319 from opf/fix/left-align-progress-modal
HDinger Apr 19, 2024
27e8573
[#53704] Visible=false project attribute values are deleted when a no…
dombesz Apr 16, 2024
6701d98
Update the aac patch to disable custom fields on the before_commit ho…
dombesz Apr 19, 2024
61204f6
Update specs.
dombesz Apr 19, 2024
f5a3960
Update spec comment.
dombesz Apr 19, 2024
17fe5e5
Revert "Update the aac patch to disable custom fields on the before_c…
dombesz Apr 19, 2024
a71513f
Update spec and allow updating hidden fields via the api.
dombesz Apr 19, 2024
db7942c
Update specs to allow enabling hidden fields.
dombesz Apr 19, 2024
1c9c555
Documentation 14.0: adding files storages permissions explanation (#1…
MayaBerd Apr 19, 2024
3dcb62c
Adding documentation on file storages troubleshooting (#15295)
MayaBerd Apr 19, 2024
c3b12b2
fix typo
dombesz Apr 19, 2024
80974a0
Merge pull request #15296 from opf/bug/53704-visible=false-project-at…
dombesz Apr 19, 2024
74331ac
update locales from crowdin [ci skip]
openprojectci Apr 20, 2024
ed6c039
update locales from crowdin [ci skip]
openprojectci Apr 20, 2024
fccda44
Merge branch 'release/14.0' into dev
openprojectci Apr 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .github/workflows/create-merge-release-into-dev-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- id: find_latest_release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.OPENPROJECT_CI_GH_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
run: |
BRANCH=$(curl -H "Authorization: token $GITHUB_TOKEN" \
Expand Down Expand Up @@ -107,4 +107,4 @@ jobs:
fi
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.OPENPROJECT_CI_GH_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions:
contents: read # to fetch code (actions/checkout)

env:
REGISTRY_IMAGE: openproject/community
REGISTRY_IMAGE: openproject/openproject

jobs:
extract_version:
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,6 @@ gemfiles.each do |file|
send(:eval_gemfile, file) if File.readable?(file)
end

gem "openproject-octicons", "~>19.9.0"
gem "openproject-octicons_helper", "~>19.9.0"
gem "openproject-octicons", "~>19.10.0"
gem "openproject-octicons_helper", "~>19.10.0"
gem "openproject-primer_view_components", "~>0.28.1"
26 changes: 13 additions & 13 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ GEM
airbrake-ruby (6.2.2)
rbtree3 (~> 0.6)
android_key_attestation (0.3.0)
appsignal (3.6.4)
appsignal (3.6.5)
rack
ast (2.4.2)
attr_required (1.0.2)
Expand All @@ -348,17 +348,17 @@ GEM
activerecord (>= 4.0.0, < 7.2)
awrence (1.2.1)
aws-eventstream (1.3.0)
aws-partitions (1.914.0)
aws-sdk-core (3.192.0)
aws-partitions (1.916.0)
aws-sdk-core (3.192.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
aws-sigv4 (~> 1.8)
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.78.0)
aws-sdk-kms (1.79.0)
aws-sdk-core (~> 3, >= 3.191.0)
aws-sigv4 (~> 1.1)
aws-sdk-s3 (1.146.1)
aws-sdk-core (~> 3, >= 3.191.0)
aws-sdk-s3 (1.147.0)
aws-sdk-core (~> 3, >= 3.192.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.8)
aws-sdk-sns (1.72.0)
Expand Down Expand Up @@ -723,7 +723,7 @@ GEM
messagebird-rest (1.4.2)
meta-tags (2.21.0)
actionpack (>= 6.0.0, < 7.2)
method_source (1.0.0)
method_source (1.1.0)
mime-types (3.5.2)
mime-types-data (~> 3.2015)
mime-types-data (3.2024.0305)
Expand Down Expand Up @@ -773,10 +773,10 @@ GEM
validate_email
validate_url
webfinger (~> 2.0)
openproject-octicons (19.9.0)
openproject-octicons_helper (19.9.0)
openproject-octicons (19.10.0)
openproject-octicons_helper (19.10.0)
actionview
openproject-octicons (= 19.9.0)
openproject-octicons (= 19.10.0)
railties
openproject-primer_view_components (0.28.1)
actionview (>= 5.0.0)
Expand Down Expand Up @@ -1119,7 +1119,7 @@ GEM
activemodel (>= 3.0.0)
public_suffix
vcr (6.2.0)
view_component (3.12.0)
view_component (3.12.1)
activesupport (>= 5.2.0, < 8.0)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
Expand Down Expand Up @@ -1271,8 +1271,8 @@ DEPENDENCIES
openproject-job_status!
openproject-ldap_groups!
openproject-meeting!
openproject-octicons (~> 19.9.0)
openproject-octicons_helper (~> 19.9.0)
openproject-octicons (~> 19.10.0)
openproject-octicons_helper (~> 19.10.0)
openproject-openid_connect!
openproject-primer_view_components (~> 0.28.1)
openproject-recaptcha!
Expand Down
6 changes: 1 addition & 5 deletions app/components/filters_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,7 @@ def allowed_filters
end

def filters_count
@filters_count ||= query
.filters
.map(&:class)
.uniq
.count
@filters_count ||= query.filters.count
end

protected
Expand Down
1 change: 1 addition & 0 deletions app/components/members/row_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ def delete_action_options
def view_work_package_shares_action_options
{
scheme: :default,
tag: :a,
icon: "op-view-list",
label: I18n.t(:button_view_shared_work_packages),
href: shared_work_packages_url
Expand Down
17 changes: 3 additions & 14 deletions app/components/projects/row_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,8 @@ See COPYRIGHT and LICENSE files for more details.
</td>
<% end %>
<td class="buttons">
<% if more_menu_items.any? %>
<ul class="project-actions">
<li aria-haspopup="true" title="<%= I18n.t(:label_open_menu) %>" class="drop-down">
<a class="icon icon-show-more-horizontal context-menu--icon" title="<%= t(:label_open_menu) %>" href></a>
<ul style="display:none;" class="menu-drop-down-container">
<% more_menu_items.each do |item| %>
<li>
<%= link_to(*item) %>
</li>
<% end %>
</ul>
</li>
</ul>
<% button_links.each do |link| %>
<%= link %>
<% end %>
</td>
</tr>
</tr>
114 changes: 81 additions & 33 deletions app/components/projects/row_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,40 @@ def additional_css_class(column)
end
end

def button_links
return [] if more_menu_items.empty?

if more_menu_items.one?
more_menu_items.first => {label:, **button_options}

[render(Primer::Beta::IconButton.new(**button_options,
size: :small,
tag: :a,
scheme: button_options[:scheme] == :default ? :invisible : button_options[:scheme],
"aria-label": label,
test_selector: "project-list-row--single-action"))]
else
[
render(Primer::Alpha::ActionMenu.new(test_selector: "project-list-row--action-menu")) do |menu|
menu.with_show_button(scheme: :invisible,
size: :small,
icon: :"kebab-horizontal",
"aria-label": t(:label_open_menu),
tooltip_direction: :w)
more_menu_items.each do |action_options|
action_options => {scheme:, label:, icon:, **button_options}
menu.with_item(scheme:,
label:,
test_selector: "project-list-row--action-menu-item",
content_arguments: button_options) do |item|
item.with_leading_visual_icon(icon:)
end
end
end
]
end
end

def more_menu_items
@more_menu_items ||= [more_menu_subproject_item,
more_menu_settings_item,
Expand All @@ -191,70 +225,84 @@ def more_menu_items

def more_menu_subproject_item
if User.current.allowed_in_project?(:add_subprojects, project)
[t(:label_subproject_new),
new_project_path(parent_id: project.id),
{ class: "icon-context icon-add",
title: t(:label_subproject_new) }]
{
scheme: :default,
icon: :plus,
label: I18n.t(:label_subproject_new),
href: new_project_path(parent_id: project.id)
}
end
end

def more_menu_settings_item
if User.current.allowed_in_project?({ controller: "/projects/settings/general", action: "show", project_id: project.id },
project)
[t(:label_project_settings),
project_settings_general_path(project),
{ class: "icon-context icon-settings",
title: t(:label_project_settings) }]
{
scheme: :default,
icon: :gear,
label: I18n.t(:label_project_settings),
href: project_settings_general_path(project)
}
end
end

def more_menu_activity_item
if User.current.allowed_in_project?(:view_project_activity, project)
[
t(:label_project_activity),
project_activity_index_path(project, event_types: ["project_attributes"]),
{ class: "icon-context icon-checkmark",
title: t(:label_project_activity) }
]
{
scheme: :default,
icon: :check,
label: I18n.t(:label_project_activity),
href: project_activity_index_path(project, event_types: ["project_attributes"]),
}
end
end

def more_menu_archive_item
if User.current.allowed_in_project?(:archive_project, project) && project.active?
[t(:button_archive),
project_archive_path(project, status: params[:status]),
{ data: { confirm: t("project.archive.are_you_sure", name: project.name) },
method: :post,
class: "icon-context icon-locked",
title: t(:button_archive) }]
{
scheme: :default,
icon: :lock,
label: I18n.t(:button_archive),
href: project_archive_path(project, status: params[:status]),
data: {
confirm: t("project.archive.are_you_sure", name: project.name),
method: :post
},
}
end
end

def more_menu_unarchive_item
if User.current.admin? && project.archived? && (project.parent.nil? || project.parent.active?)
[t(:button_unarchive),
project_archive_path(project, status: params[:status]),
{ method: :delete,
class: "icon-context icon-unlocked",
title: t(:button_unarchive) }]
{
scheme: :default,
icon: :unlock,
label: I18n.t(:button_unarchive),
href: project_archive_path(project, status: params[:status]),
data: { method: :delete }
}
end
end

def more_menu_copy_item
if User.current.allowed_in_project?(:copy_projects, project) && !project.archived?
[t(:button_copy),
copy_project_path(project),
{ class: "icon-context icon-copy",
title: t(:button_copy) }]
{
scheme: :default,
icon: :copy,
label: I18n.t(:button_copy),
href: copy_project_path(project),
}
end
end

def more_menu_delete_item
if User.current.admin
[t(:button_delete),
confirm_destroy_project_path(project),
{ class: "icon-context icon-delete",
title: t(:button_delete) }]
{
scheme: :danger,
icon: :trash,
label: I18n.t(:button_delete),
href: confirm_destroy_project_path(project),
}
end
end

Expand Down
Loading
Loading