[pull] dev from opf:dev #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…0437-easy-emoji-reactions,-eg-thumbs-up-on-activity-entries
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…e/40437-emoji-reactions-to-work-package-comments
…s not reacted as requested by @psatyal
…e/40437-emoji-reactions-to-work-package-comments
Users who do not have commenting permissions: typically the `add_work_package_notes` and anonymous users cannot add new reactions but they can view any existing reactions. Futher, the "Add reactions" button is also hidden from them. In view only state, the emoji reactions render as primer invisible buttons in disabled state. > They can respond to user input and provide feedback, but it does not trigger any actions. > See: https://primer.style/components/button#inactive The view only reactions mimic primer inactive buttons but without the muted styling and cursor change
Bumps [pg](https://github.com/ged/ruby-pg) from 1.5.8 to 1.5.9. - [Changelog](https://github.com/ged/ruby-pg/blob/master/History.md) - [Commits](ged/ruby-pg@v1.5.8...v1.5.9) --- updated-dependencies: - dependency-name: pg dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…-table-cell-editing-ui-has-wrong-colors [58108] Dark mode: "Custom text" widget - table cell editing UI has wrong colors
… outline appears (update core) (#17039) * update core with new version of octicon and primer view components * fix missing version update
…ll component refresh
- https://community.openproject.org/work_packages/58426 - add a couple of test selectors - add page objects
Emoji Reactions should always be returned in their current state, timeslicing will yield incorrect results. At any given time, we ONLY need to know what reactions a Journal has. Further, EmojiReactions are never updated, rather created and destroyed. Retain timeslicing only for the journal render- where that is relevant to find updated journals
Bump pg from 1.5.8 to 1.5.9
- add regions to different steps of the feature spec - removed expectations from page object
Journalsa are updated on last updated_at; reactions cannot rely on this as they do not "touch" the journal, so a full journal refresh would not be viable. We avoid "touching" the journal on emoji reactions update to retain concurrent user actions. E.g. If a user has a journal in edit mode, we do not want to overrite it on the next polling update- this is why it's safer to stream emoji reactions separately This reverts commit fb419dd.
…pec-covering-the-hierarchy-lifecycle-in-the-admin-view [#58426] add feature spec for custom fields of type hierarchy
See: https://guides.rubyonrails.org/i18n.html#pluralization Co-authored-by: Eric Schubert <e.schubert@openproject.com>
Use both hex codes to ensure red color! Tested on Safari
…ork-package-comments Feature/40437 emoji reactions to work package comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )