WIP add support for Babashka #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding changes are marked as FIXME - added :bb specific reader conditionals - made `expound` an optional dependency - made `cljc.java-time` a required dependency - combined optionals.clj and .cljs into .cljc - combined platform.clj and .cljs into .cljc - created `bb-test.sh` and `bb_runner.cljc` to running tests in Babashka - a lot of simplification and cleanup
AndreTheHunter
changed the title
AndreTheHunter
changed the title
AndreTheHunter
changed the title
|
Phew, that was quite the rampage. Happy to answer any questions or discuss any changes/improvements. Feel free to jump in since "Allow edits and access to secrets by maintainers" is on. @l3nz |
This was referenced Jun 25, 2020
|
Sorry I clicked on wrong button. :-) Couple of comments:
In general, good job! very torough. Having bb would be major (and being included in bb even more :-) ) |
|
Closing because of #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#113
expoundan optional dependencycljc.java-timea required dependencybb-test.shandbb_runner.cljcfor running tests in BabashkaTODO
Outstanding changes are marked as FIXME