change(syncer): only remove temporary bans when service account serve…

…r is not running

this is because we cannot guarantee the service account(s) used on gclone/rclone start, are the ones that it finished with due to on-fly sa cycling

syncer/copy.go

@@ -62,7 +62,10 @@ func (s *Syncer) Copy(additionalRcloneParams []string) error {
 				return errors.WithMessagef(err, "copy failed unexpectedly with exit code: %v", exitCode)
 			} else if success {
 				// successful exit code
-				rclone.RemoveServiceAccountsFromTempCache(serviceAccounts)
+				if !s.Ws.Running {
+					// web service is not running (no gclone)
+					rclone.RemoveServiceAccountsFromTempCache(serviceAccounts)
+				}
 				break
 			}
 

syncer/sync.go

@@ -62,7 +62,10 @@ func (s *Syncer) Sync(additionalRcloneParams []string) error {
 				return errors.WithMessagef(err, "sync failed unexpectedly with exit code: %v", exitCode)
 			} else if success {
 				// successful exit code
-				rclone.RemoveServiceAccountsFromTempCache(serviceAccounts)
+				if !s.Ws.Running {
+					// web service is not running (no gclone)
+					rclone.RemoveServiceAccountsFromTempCache(serviceAccounts)
+				}
 				break
 			}
 

syncer/web.go

@@ -14,6 +14,7 @@ import (
 type WebServer struct {
 	Host       string
 	Port       int
+	Running    bool
 	app        *fiber.App
 	log        *logrus.Entry
 	syncerName string
@@ -86,10 +87,13 @@ func newWebServer(host string, log *logrus.Entry, syncerName string, sa *rclone.
 func (ws *WebServer) Run() {
 	go func() {
 		ws.log.Infof("Starting service account server on %s:%d", ws.Host, ws.Port)
+		ws.Running = true
 
 		if err := ws.app.Listen(fmt.Sprintf("%s:%d", ws.Host, ws.Port)); err != nil {
 			ws.log.WithError(err).Error("Service account server failed...")
 		}
+
+		ws.Running = false
 	}()
 }