fix: fix(ssr) textarea domProps keeps falsy values (vuejs#10803)

lKk2 · Feb 12, 2020 · 288c671 · 288c671
1 parent 6390f70
commit 288c671
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/platforms/web/server/modules/dom-props.js b/src/platforms/web/server/modules/dom-props.js
@@ -27,7 +27,7 @@ export default function renderDOMProps (node: VNodeWithData): string {
       setText(node, props[key], true)
     } else if (key === 'textContent') {
       setText(node, props[key], false)
-    } else if (key === 'value' && node.tag === 'textarea') {
+    } else if (props[key] && key === 'value' && node.tag === 'textarea') {
       setText(node, props[key], false)
     } else {
       // $flow-disable-line (WTF?)

diff --git a/test/ssr/ssr-string.spec.js b/test/ssr/ssr-string.spec.js
@@ -1222,6 +1222,26 @@ describe('SSR: renderToString', () => {
     })
   })
 
+    // SSR: textarea domProps keeps falsy values #10803
+    it('falsy domProps value', done => {
+      renderVmWithOptions({
+        render(h) {
+          return h('div', [
+            h('textarea', {
+              domProps: {
+                value: null
+              }
+            })
+          ])
+        }
+      }, result => {
+        expect(result).toContain(
+          '<div data-server-rendered="true"><textarea></textarea></div>'
+        )
+        done()
+      })
+    })
+
   it('render v-model with <select> (value binding)', done => {
     renderVmWithOptions({
       data: {