Render Contentful rich text content #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benaiah
force-pushed
the
benaiah/render-contentful-content
branch
from
e76a8ea to
9091841
Compare
2 tasks
Benaiah
force-pushed
the
benaiah/render-contentful-content
branch
from
fe05198 to
bb8019d
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Benaiah
commented
May 4, 2023
|
|
||
| declare global { | ||
| /* eslint-disable-next-line @typescript-eslint/no-namespace */ | ||
| namespace Vi { |
There was a problem hiding this comment.
This will need to be updated if we merge the vitest dependency update (#105) first.
LouisFettet
reviewed
May 4, 2023
Benaiah
force-pushed
the
benaiah/render-contentful-content
branch
from
0ee2420 to
460dbf6
Compare
LouisFettet
reviewed
May 5, 2023
src/lib/components/ContentfulRichText/__tests__/documents/markdown-document.md
Show resolved
Hide resolved
src/lib/components/ContentfulRichText/__tests__/documents/.generate-documents-from-markdown.cjs
Outdated
Show resolved
Hide resolved
Benaiah
force-pushed
the
benaiah/render-contentful-content
branch
from
5026cb6 to
ce4d64f
Compare
LouisFettet
approved these changes
May 5, 2023
|
Coverage after merging benaiah/render-contentful-content into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Reports for unit and end-to-end tests of 1b2a12a have been committed to the You can view the unit test coverage report, the end-to-end test report, and the bundle visualizer once changes have propagated (this may take a few minutes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: LDAF-211
Proposed changes
ContentfulRichTextcomponent that renders regular Contentful rich text./test-contenful-contentthat uses theContentfulRichTextcomponent.Screenshots
Screenshot is of the Contentful rich text preview page.
Acceptance criteria validation