OnceLock is stabilized in 1.70.0 but current MSRV is 1.67.1

[rnbguy]

#237 introduces the use of OnceLock

rstest/rstest_macros/src/render/fixture.rs

Lines 25 to 26 in 9df2cc1

	static CELL: std::sync::OnceLock<#t> =
	std::sync::OnceLock::new();

But OnceLock is stabilized in 1.70.0. Shouldn't the MSRV of rstest be 1.70.0 ?

[la10736]

You're right 😢

I trusted cargo hack check --rust-version --workspace --ignore-private but maybe it use just the provided msrv from the other packages.... I need to change it.

Thank to report it

[rnbguy]

Thanks for quick reply 🙂

I think, it is a bit nuanced to find the breakage via MSRV finder (I use cargo-msrv) - because OnceLock is not being used inside rstest - it is only imported inside the macro generated code.

I think, it would be better to include running the tests at the MSRV version 😉

rstest/.github/workflows/test.yml

Lines 34 to 39 in 9df2cc1

	- name: Run tests stable
	run: RSTEST_TEST_CHANNEL=stable cargo test --all --verbose
	- name: Run tests beta
	run: RSTEST_TEST_CHANNEL=beta cargo test --all --verbose
	- name: Run tests nightly
	run: RSTEST_TEST_CHANNEL=nightly cargo test --all --verbose

PS. I found out about this via cargo +nightly clippy which is autoconfigured in my IDE.